client: Maximum call stack size exceeded bursts during teleport loading; the report carried no stack (journal dedup)

Offen
#3,425 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
42/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
frontend, tooling

Rechercherichtung

Start in bug-report/journal.ts at recordError to see why the error event is missing from timeline.json, then check the dedup and export filter in archive.ts and the message-only listError in bug-report.ts. Reproduce by opening the Att.Grant window at the Donwhang blacksmith and scrolling with the magic-option-down control while watching the console for the stack. Done when the recursion is fixed with a test and a repeating error's first stack reaches the report.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area: client bug priority: high

Report: https://discord.com/channels/1550530470430396426/1570495242120200334 (BR-261112-1747-51F8)

The report's "Recent client errors" field lists Uncaught RangeError: Maximum call stack size exceeded once at 12:54:01 and then about once a second from 12:55:09 to the report. The player was at the Donwhang blacksmith with the Att.Grant (avatar magic option) window open, scrolling its option list; the replay shows the window and the world working.

Gap: the report's timeline.json holds no error event at all, though the journal records errors with their stack (bug-report/journal.ts recordError) and the archive allows the error kind and stack field (archive.ts). So nothing tells us which code recursed. The embed's error list comes from bug-report.ts listError, which keeps only the message.

Next steps:

  1. Find out why the journal's error event is missing from the timeline: dedup by signature, the journal window, or the export filter dropping the event.
  2. Reproduce: open the blacksmith's Att.Grant with a dress inserted and scroll the option list (the magic-option-down control) with the browser console open, and capture the stack.
  3. Fix the recursion, and make sure a report always carries the first stack of a repeating error.

Done when the recursion is found and fixed with a test, and a report of a repeating error carries its stack.

Vorherrschende Sprache
Go
Sterne
97
Forks
61
Ø Merge
4 Std. 14 Min.
Gemergte PRs (30 T.)
913

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus opensro-dev/opensro

Alle Issues in opensro-dev/opensro

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.