client: what native draws for a UI image whose texture failed to load

Aperta
#3,416 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
18/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript, wasm
Ambito
frontend, game-dev

Direzione di ricerca

Start in resources.ts, where a manifest-absent image is sent to missing and its quad is left blank, and compare that with the native path described in the issue (CTextBoard_SetTexturePath, CIFWnd_RenderTexturedFace, CIFWnd_RenderBackgroundTexture). The first open question is the UI texture stage-0 colour/alpha state, which the issue says is not yet traced, so it must be traced before any port change. Done means the device calls before 0x53F584 are documented and the port draws the same for an absent image, with a test, or the issue is closed with the trace showing native draws nothing.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: client bug priority: critical

Found while tracing #3407 in the v1.150 client.

The port draws nothing for a UI image the build lacks (resources.ts: a manifest-absent image goes to missing and its quad is blank). Native keeps drawing the face:

  • CTextBoard_SetTexturePath 0x53FF00 stores ResourceManager_GetTextureByPath's result at +0xD8 (null for a missing file) and sets the path flag +0xFC.
  • CIFWnd_RenderTexturedFace 0x5405DF draws when +0xFC is set, whether or not the texture loaded.
  • CIFWnd_RenderBackgroundTexture 0x53F4E1→0x53F4F8 binds +0xD8 as is (null included) and draws the quad (0x53F584).

So with no texture, native draws the quad with no texture bound. What that looks like (vertex colour, white or black) depends on the texture stage state the UI sets for stage 0, which hasn't been traced yet.

Done when

  • The UI's stage-0 colour/alpha ops are traced (the device calls before 0x53F584), so we know what a null-texture quad shows in native.
  • The port draws the same for an absent image, with a test. If native shows nothing, close with that trace instead.
Lingua principale
Go
Stelle
97
Fork
61
Merge medio
4h 14m
PR unite (30g)
913

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di opensro-dev/opensro

Tutte le issue di opensro-dev/opensro

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.