client: what native draws for a UI image whose texture failed to load

Abierto
#3,416 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
18/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript, wasm

Línea de trabajo

Start in resources.ts, where a manifest-absent image is sent to missing and its quad is left blank, and compare that with the native path described in the issue (CTextBoard_SetTexturePath, CIFWnd_RenderTexturedFace, CIFWnd_RenderBackgroundTexture). The first open question is the UI texture stage-0 colour/alpha state, which the issue says is not yet traced, so it must be traced before any port change. Done means the device calls before 0x53F584 are documented and the port draws the same for an absent image, with a test, or the issue is closed with the trace showing native draws nothing.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: client bug priority: critical

Found while tracing #3407 in the v1.150 client.

The port draws nothing for a UI image the build lacks (resources.ts: a manifest-absent image goes to missing and its quad is blank). Native keeps drawing the face:

  • CTextBoard_SetTexturePath 0x53FF00 stores ResourceManager_GetTextureByPath's result at +0xD8 (null for a missing file) and sets the path flag +0xFC.
  • CIFWnd_RenderTexturedFace 0x5405DF draws when +0xFC is set, whether or not the texture loaded.
  • CIFWnd_RenderBackgroundTexture 0x53F4E1→0x53F4F8 binds +0xD8 as is (null included) and draws the quad (0x53F584).

So with no texture, native draws the quad with no texture bound. What that looks like (vertex colour, white or black) depends on the texture stage state the UI sets for stage 0, which hasn't been traced yet.

Done when

  • The UI's stage-0 colour/alpha ops are traced (the device calls before 0x53F584), so we know what a null-texture quad shows in native.
  • The port draws the same for an absent image, with a test. If native shows nothing, close with that trace instead.
Lenguaje dominante
Go
Estrellas
97
Forks
61
Merge medio
4 h 14 min
PR fusionados (30 d)
913

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de opensro-dev/opensro

Todos los issues de opensro-dev/opensro

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.