client: what native draws for a UI image whose texture failed to load

Offen
#3,416 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
18/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
typescript, wasm
Bereich
frontend, game-dev

Rechercherichtung

Start in resources.ts, where a manifest-absent image is sent to missing and its quad is left blank, and compare that with the native path described in the issue (CTextBoard_SetTexturePath, CIFWnd_RenderTexturedFace, CIFWnd_RenderBackgroundTexture). The first open question is the UI texture stage-0 colour/alpha state, which the issue says is not yet traced, so it must be traced before any port change. Done means the device calls before 0x53F584 are documented and the port draws the same for an absent image, with a test, or the issue is closed with the trace showing native draws nothing.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area: client bug priority: critical

Found while tracing #3407 in the v1.150 client.

The port draws nothing for a UI image the build lacks (resources.ts: a manifest-absent image goes to missing and its quad is blank). Native keeps drawing the face:

  • CTextBoard_SetTexturePath 0x53FF00 stores ResourceManager_GetTextureByPath's result at +0xD8 (null for a missing file) and sets the path flag +0xFC.
  • CIFWnd_RenderTexturedFace 0x5405DF draws when +0xFC is set, whether or not the texture loaded.
  • CIFWnd_RenderBackgroundTexture 0x53F4E1→0x53F4F8 binds +0xD8 as is (null included) and draws the quad (0x53F584).

So with no texture, native draws the quad with no texture bound. What that looks like (vertex colour, white or black) depends on the texture stage state the UI sets for stage 0, which hasn't been traced yet.

Done when

  • The UI's stage-0 colour/alpha ops are traced (the device calls before 0x53F584), so we know what a null-texture quad shows in native.
  • The port draws the same for an absent image, with a test. If native shows nothing, close with that trace instead.
Vorherrschende Sprache
Go
Sterne
97
Forks
61
Ø Merge
4 Std. 14 Min.
Gemergte PRs (30 T.)
913

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus opensro-dev/opensro

Alle Issues in opensro-dev/opensro

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.