[Feature]: Add generalized gamma index likelihood

Aperta

#497 aperta il 18/8/2023 16 commenti 0 reazioni 3 assegnatari Vedi su GitHub

@Cole-Monnahan-NOAA ci sta già lavorando.

Dal 10/10/2023.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

statistics survey_&_Q wishlist

Describe the solution you would like.

In many cases I believe it is more statistically justifiable to use a more flexible index likelihood than the lognormal. One appealing alternative is the generalized gamma distribution (GGD). It requires reading in a third parameter ("Q"), and has a complicated PDF function.

I forked the repo and have added a prototype on this branch and it appears to work well on the few models I've tested. It also does not appear to break backwards compatibility because the new data are only read in with the new likelihood option.

The point of this issue is to gauge the interest in this feature by the SS3 team for incorporating this into a future release of SS3. IF so, how should I proceed with development (git workflow, timing, testing, etc.)?

I think the only other main component to add is a simulator for the bootstrapper, and perhaps some reporting? I'll need help with the latter. I also need to further comment the code and update the documentation.

Describe alternatives you have considered

None so far

Statistical validity, if applicable

In many (most?) cases there is no statistical justification for assuming a lognormal index resulting from a design-based or model-based estimator. This is because sums of positive r.v.s are not necessarily lognormal, even if each r.v. is lognormal. Thus a more flexible distribution which can more accurately convey the information in the survey biomass indices is needed.

Describe if this is needed for a management application

No response

Additional context

No response

Lingua principale: C++
Stelle: 46
Fork: 19
Metriche di merge delle PR: Nessuna PR unita negli ultimi 30g

Guida per i contributori

Apri la guida per i contributori

Come iniziare

Leggi tutta la issue e poi la guida ai contributi del progetto.
Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
Fai un fork del repository e lavora su un branch.
Apri una pull request che faccia riferimento al numero della issue.