need warning and improved logic for generalized sizecomp
@Rick-Methot-NOAA ci sta già lavorando.
Dal 2/2/2026.
Valutazione
Questa issue non è ancora stata valutata.
Descrizione
A user configured a generalized sizecomp with narrow weight bins for the data. SS3 crashed without providing warning. The problem is that when the setup is using weight bins, a narrow population length bin can translate to weight range that is wider than the user-specified weight bins.
@N-DucharmeBarth-NOAA
The code is designed to detect where the population bin is completely within a data bin and assign all of that pop bin to the data bin, and to detect when there are multiple consecutive pop bins that fall within the same data bin range and assign all of them to that range. It also can detect when a pop bin stradles the upper edge of a data bin and apportion that pop bin to the current and nect data bin, then to correctly move on to the next pop bin.
However, the code cannot detect when the upper edge of a pop bin would skip over a data bin. When this happens, no warning is issued and a crash typically occurs.
- minimum fix would be to provide a fatal warning in all such circumstances
- best fix would be to develop an algorithm by which the code would apportion that wide population bin to a range of data bins. Surely such an algorithm has already been developed somewhere and we just need to know what to ask for.
- Lingua principale
- C++
- Stelle
- 46
- Fork
- 19
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di nmfs-ost/ss3-source-code
-
area & movement
nmfs-ost/ss3-source-code#731 · 3 commenti · 1 assegnatario ·
-
misc. output
nmfs-ost/ss3-source-code#723 · 1 assegnatario ·
-
biology misc. output ongoing
nmfs-ost/ss3-source-code#702 · 1 assegnatario ·
-
recruitment
nmfs-ost/ss3-source-code#696 · 1 assegnatario ·
-
misc. input recruitment wishlist
nmfs-ost/ss3-source-code#660 · 1 assegnatario ·
Tutte le issue di nmfs-ost/ss3-source-code
Issue simili
-
ai_reviewed
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
ydb-platform/ydb#53869 · 3 commenti ·
-
bug cert blocker needs triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
project-chip/connectedhomeip#74373 ·
-
[request] tracy/0.14.1 Apertaupstream update
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
conan-io/conan-center-index#31035 ·
-
Bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
-
documentation
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 85/100
vllm-project/vllm-ascend#17329 ·