Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

ensure results are returned even when `code-review` task doesn't run automatically

Aperta
  • Qualcosa non va?
#3,740 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@bhearsum ci sta già lavorando.

Dal 21/10/2026.

  • #3751 di @bhearsum — aperta

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Da chiarire
Stato di attività
Attiva
Stack tecnologico
python
Ambito
ci-cd, devtools

Direzione di ricerca

Start by reading the discussion in pull request 3720 and trace how the code-review task and publication task are scheduled when upstream tasks do not run. Verify the behavior of Taskcluster's taskGroupResolved exchange and compare it with the cron option described here. Done means a chosen approach reliably publishes results and resolves Phabricator builds when an upstream task is skipped.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Some discussion in https://github.com/mozilla/code-review/pull/3720 has highlighted the fact that it's possible for us never to publish status of a phab revision or github pull request. Because this happens in the publication task, and that publication task only runs when a code-review task completes, any issues that cause any of the direct upstream of that task not to run will result in the publication task never running. This, in turn, causes no feedback to be posted to github or phabricator, and worse yet, builds on phabricator not to be resolved. This is a more likely problem for builds and tests, but it is still possible to happen for linting as well.

It's not immediately clear to me how to deal with this. There is no way that I'm aware of to make the code-review tasks run when a direct upstream does not. Some ideas could be:

  • Run something on a cron schedule that looks for reviewbot task groups that are not doing anything, but haven't run code-review. Then, somehow kick that task to run, or directly schedule the publication task for them. The main downside to this is that unless we run this very frequently, we delay results.
  • Fire something on task-group-resolved. I believe this fires whenever a task group is idle (even if not all tasks have completed) - but this needs to be verified. This event doesn't have enough information in its payload to immediately fire a publication task; we'd need to run some small task to determine if it's a group we care about, and then to force the code-review task to run or directly schedule the publication task if it is.
Lingua principale
Python
Stelle
68
Fork
53
Merge medio
1g 13h
PR unite (30g)
52

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di mozilla/code-review

Tutte le issue di mozilla/code-review

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.