Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Drain subprocess pipes while probing interpreters and standardize probe deadlines

Aperta
#530 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
32/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust

Direzione di ricerca

Start by reading crates/pet-python-utils/src/env.rs, crates/pet-conda/src/conda_info.rs, and crates/pet-poetry/src/environment_locations_spawn.rs to compare the existing probe and subprocess paths. Run the relevant test suite, then verify the shared runner against the listed pipe, timeout, cleanup, output, and Windows/Unix acceptance cases without regressing interpreter discovery or benchmark behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Tracking plan: #528
Priority: P1. Evidence: pipe backpressure reproduced; other runner gaps confirmed by source inspection.

Problem and evidence

The interpreter probe pipes stdout/stderr, polls for child exit, and only then calls wait_with_output. A child that fills a pipe cannot exit until PET drains it, so a healthy interpreter is killed by the timeout.

A temporary Python startup fixture writing 128 KiB to stderr exited successfully in 217 ms when its output was drained normally. Resolving the same interpreter through PET took 15,111 ms and returned a timeout error. These are Windows debug-build diagnostic measurements, not release budgets.

Sources: interpreter probe, Conda subprocess, Poetry subprocess.

The interpreter deadline currently starts after process creation. Conda/Poetry blocking output calls do not share equivalent timeout/cleanup semantics. Do not claim that a deadline bounds a synchronous OS process-creation call unless the implementation actually does so.

Scope

Introduce the smallest reusable process runner needed for interpreter and manager probes: concurrent pipe draining, bounded retained output, explicit exit/parse/I/O errors, deadlines, and child cleanup. Preserve the file-first discovery policy and do not add new spawn fallbacks. Define behavior for descendants retaining pipe handles and for capture-limit exhaustion; do not silently truncate valid protocol data into success.

The non-UTF-8 panic already belongs to #525 / #526. Reuse that fix rather than duplicating it, and retain its regression tests while changing the runner.

Acceptance criteria

  • A healthy fixture emitting more than pipe capacity on stdout and/or stderr completes without waiting for the 15-second timeout.
  • Hanging child, malformed output, nonzero exit, invalid UTF-8, and output-limit cases return explicit outcomes without panic or abandoned RPCs.
  • Timeout/cleanup behavior has Windows and Unix tests, including an inherited-pipe case; tests clean up every process they create.
  • Conda and Poetry probe call sites use the established deadline/error contract, with no unbounded output wait hidden behind an RPC.
  • Captured memory stays within a documented limit while pipes continue to be drained or the child is terminated deliberately.
  • Quiet successful interpreter probes preserve existing environment output and do not regress the relevant release benchmark budgets.

Dependencies

Coordinate implementation after #525 / #526 because both touch interpreter-output handling. Bounded request scheduling and sharing failed in-flight probes are separate follow-up work in #539. Reuse this runner from the #533 workload harness; the complete plan is #528.

Lingua principale
Rust
Stelle
207
Fork
45
Merge medio
3g 6h
PR unite (30g)
12

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di microsoft/python-environment-tools

Tutte le issue di microsoft/python-environment-tools

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.