Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Drain subprocess pipes while probing interpreters and standardize probe deadlines

未关闭
#530 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
32/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
rust

调研方向

Start by reading crates/pet-python-utils/src/env.rs, crates/pet-conda/src/conda_info.rs, and crates/pet-poetry/src/environment_locations_spawn.rs to compare the existing probe and subprocess paths. Run the relevant test suite, then verify the shared runner against the listed pipe, timeout, cleanup, output, and Windows/Unix acceptance cases without regressing interpreter discovery or benchmark behavior.

由索引模型根据 Issue 内容生成。

描述

bug

Tracking plan: #528
Priority: P1. Evidence: pipe backpressure reproduced; other runner gaps confirmed by source inspection.

Problem and evidence

The interpreter probe pipes stdout/stderr, polls for child exit, and only then calls wait_with_output. A child that fills a pipe cannot exit until PET drains it, so a healthy interpreter is killed by the timeout.

A temporary Python startup fixture writing 128 KiB to stderr exited successfully in 217 ms when its output was drained normally. Resolving the same interpreter through PET took 15,111 ms and returned a timeout error. These are Windows debug-build diagnostic measurements, not release budgets.

Sources: interpreter probe, Conda subprocess, Poetry subprocess.

The interpreter deadline currently starts after process creation. Conda/Poetry blocking output calls do not share equivalent timeout/cleanup semantics. Do not claim that a deadline bounds a synchronous OS process-creation call unless the implementation actually does so.

Scope

Introduce the smallest reusable process runner needed for interpreter and manager probes: concurrent pipe draining, bounded retained output, explicit exit/parse/I/O errors, deadlines, and child cleanup. Preserve the file-first discovery policy and do not add new spawn fallbacks. Define behavior for descendants retaining pipe handles and for capture-limit exhaustion; do not silently truncate valid protocol data into success.

The non-UTF-8 panic already belongs to #525 / #526. Reuse that fix rather than duplicating it, and retain its regression tests while changing the runner.

Acceptance criteria

  • A healthy fixture emitting more than pipe capacity on stdout and/or stderr completes without waiting for the 15-second timeout.
  • Hanging child, malformed output, nonzero exit, invalid UTF-8, and output-limit cases return explicit outcomes without panic or abandoned RPCs.
  • Timeout/cleanup behavior has Windows and Unix tests, including an inherited-pipe case; tests clean up every process they create.
  • Conda and Poetry probe call sites use the established deadline/error contract, with no unbounded output wait hidden behind an RPC.
  • Captured memory stays within a documented limit while pipes continue to be drained or the child is terminated deliberately.
  • Quiet successful interpreter probes preserve existing environment output and do not regress the relevant release benchmark budgets.

Dependencies

Coordinate implementation after #525 / #526 because both touch interpreter-output handling. Bounded request scheduling and sharing failed in-flight probes are separate follow-up work in #539. Reuse this runner from the #533 workload harness; the complete plan is #528.

主要语言
Rust
星标
207
派生
45
平均合并
3 天 6 小时
30 天内合并 PR
12

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

microsoft/python-environment-tools 的其他 Issue

查看 microsoft/python-environment-tools 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。