Drain subprocess pipes while probing interpreters and standardize probe deadlines
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Accessibilité débutants
- 32/100
- Type d'issue
- Fonctionnalité
- Clarté
- Plutôt claire
- Activité
- Active
- Stack technique
- rust
- Domaine
- testing-qa, tooling
Piste de recherche
Start by reading crates/pet-python-utils/src/env.rs, crates/pet-conda/src/conda_info.rs, and crates/pet-poetry/src/environment_locations_spawn.rs to compare the existing probe and subprocess paths. Run the relevant test suite, then verify the shared runner against the listed pipe, timeout, cleanup, output, and Windows/Unix acceptance cases without regressing interpreter discovery or benchmark behavior.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Tracking plan: #528
Priority: P1. Evidence: pipe backpressure reproduced; other runner gaps confirmed by source inspection.
Problem and evidence
The interpreter probe pipes stdout/stderr, polls for child exit, and only then calls wait_with_output. A child that fills a pipe cannot exit until PET drains it, so a healthy interpreter is killed by the timeout.
A temporary Python startup fixture writing 128 KiB to stderr exited successfully in 217 ms when its output was drained normally. Resolving the same interpreter through PET took 15,111 ms and returned a timeout error. These are Windows debug-build diagnostic measurements, not release budgets.
Sources: interpreter probe, Conda subprocess, Poetry subprocess.
The interpreter deadline currently starts after process creation. Conda/Poetry blocking output calls do not share equivalent timeout/cleanup semantics. Do not claim that a deadline bounds a synchronous OS process-creation call unless the implementation actually does so.
Scope
Introduce the smallest reusable process runner needed for interpreter and manager probes: concurrent pipe draining, bounded retained output, explicit exit/parse/I/O errors, deadlines, and child cleanup. Preserve the file-first discovery policy and do not add new spawn fallbacks. Define behavior for descendants retaining pipe handles and for capture-limit exhaustion; do not silently truncate valid protocol data into success.
The non-UTF-8 panic already belongs to #525 / #526. Reuse that fix rather than duplicating it, and retain its regression tests while changing the runner.
Acceptance criteria
- A healthy fixture emitting more than pipe capacity on stdout and/or stderr completes without waiting for the 15-second timeout.
- Hanging child, malformed output, nonzero exit, invalid UTF-8, and output-limit cases return explicit outcomes without panic or abandoned RPCs.
- Timeout/cleanup behavior has Windows and Unix tests, including an inherited-pipe case; tests clean up every process they create.
- Conda and Poetry probe call sites use the established deadline/error contract, with no unbounded output wait hidden behind an RPC.
- Captured memory stays within a documented limit while pipes continue to be drained or the child is terminated deliberately.
- Quiet successful interpreter probes preserve existing environment output and do not regress the relevant release benchmark budgets.
Dependencies
Coordinate implementation after #525 / #526 because both touch interpreter-output handling. Bounded request scheduling and sharing failed in-flight probes are separate follow-up work in #539. Reuse this runner from the #533 workload harness; the complete plan is #528.
- Langage dominant
- Rust
- Étoiles
- 207
- Forks
- 45
- Merge moyen
- 3 j 6 h
- PR mergées (30 j)
- 12
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de microsoft/python-environment-tools
-
enhancement
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 35/100
-
debt
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 25/100
microsoft/python-environment-tools#538 · 1 commentaire ·
-
enhancement
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 35/100
-
debt
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 35/100
-
enhancement
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 35/100
microsoft/python-environment-tools#533 · 2 commentaires ·
Toutes les issues de microsoft/python-environment-tools
Issues similaires
-
Difficulté 2/5 1-3 heures Accessibilité débutants 88/100
-
bug core
Difficulté 2/5 1-3 heures Accessibilité débutants 86/100
-
JIT-compiled number -> Decimal conversion silently overflows instead of raising DECIMAL_OVERFLOW Ouvertefuzz
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
ClickHouse/ClickHouse#122114 ·
-
Difficulté 1/5 Moins d'une heure Accessibilité débutants 92/100
linebender/vello_svg#90 ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 74/100