Consolidate discovery module ownership and split JSONRPC orchestration responsibilities
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 25/100
Direzione di ricerca
Start with the binary module declarations in crates/pet/src/main.rs, the public modules in crates/pet/src/lib.rs, and the orchestration in crates/pet/src/jsonrpc.rs. Review the landing order in #528 and dependencies #536, #539, and #540 before separating responsibilities. Done means behavior, ordering, state-sync semantics, coverage, documentation, formatting, tests, and warnings-as-errors checks remain intact.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Tracking plan: #528
Priority: P3. Evidence: source-confirmed maintainability and duplicate-compilation concern; no runtime speedup is assumed.
Problem
The JSONRPC orchestration module combines handlers, configuration publication/rollback, refresh coordination, locator state transfer, and telemetry follow-up. The binary also declares find/locators modules that are already public modules in the library, creating parallel module instances instead of using one implementation boundary.
Sources: binary module declarations, library modules, JSONRPC orchestration.
Scope
Use the library discovery/locator implementation from both CLI and server entry points. Extract configuration publication and refresh coordination into independently testable components, leaving RPC handlers as thin adapters. Keep locator crates and priority ordering; avoid a workspace-wide crate merger or async rewrite.
Separate behavior changes from code movement so reviewers can verify this is behavior-preserving. Update architecture/state documentation to the final ownership model, including actual transient-versus-persistent cache lifetimes and all current locators such as Hatch. Move tests with their responsibilities without losing coverage or weakening assertions.
Acceptance criteria
- Binary and library no longer compile separate find/locators module instances; public interfaces remain deliberate and minimal.
- Configuration publication, refresh coordination, and handler adaptation have distinct, directly testable responsibilities.
- Existing CLI/JSONRPC output, error behavior, locator order, coalescing, generation checks, and state-sync semantics remain unchanged.
- Full default-feature tests, relevant feature/platform jobs, formatting, and warnings-as-errors lint pass.
- #531/#533 performance and #534 production coverage do not regress; no unmeasured runtime-speedup claim is used to justify the refactor.
- Documentation reflects the implementation and the change does not introduce generic abstractions used only once.
Dependencies
Perform after #536, bounded scheduling #539, and output ownership #540 stabilize; the complete landing order is in #528. Use #534 coverage and #531/#533 measurements as guardrails. Smaller purely mechanical library-module reuse can be split out earlier if isolated and separately reviewed.
- Lingua principale
- Rust
- Stelle
- 207
- Fork
- 45
- Merge medio
- 8h 19m
- PR unite (30g)
- 2
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di microsoft/python-environment-tools
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
microsoft/python-environment-tools#525 · 1 commento ·
-
enhancement
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
-
enhancement
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
-
debt
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
-
enhancement
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
Tutte le issue di microsoft/python-environment-tools
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
Eynzof/Hermes-CN-Desktop#616 ·
-
bug rules
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
-
app bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
IronCoreLabs/ironcore-alloy#346 ·
-
good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100