Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Receiver helpers work against a chosen database

Aperta
  • Qualcosa non va?
#367 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
52/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
django, python
Ambito
backend, databases

Direzione di ricerca

Start with morango/sync/utils.py:72 and morango/models/core.py at update_fsics and calculate_filter_specific_instance_counters, then review the SyncDatabase pattern from #365. Run the characterization suites from #363 and #364 while checking the queries identified at core.py:690-705, 735, and 775. Done means the listed helpers honor an optional handle, pinned default2 tests avoid default, and existing callers and validation errors retain their behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

DEV: backend P0 - critical TAG: tech update / debt

Overview

This task (milestone M2) lets the public receiver helpers run against a database that the caller names. The helpers are buffer validation and the two counter (FSIC) functions.

Background & Motivation

The archive receives records the same way that a network server does. It validates incoming buffers, computes its counters, and updates its counters after dequeue. These helpers are public, and hosts call some of them. Thus each helper needs an optional database parameter. If a caller gives no database, the helper keeps the current behavior.

Design: spec. Plan: implementation plan, Task 6.

Description & Expected Outcomes

Each helper takes db=None. If the caller gives no handle, the helper uses the routed default handle, so existing callers see no change. If the caller gives a handle, all queries and writes in the helper go to that database.

The dequeue function from #366 passes its handle to the counter update.

Deliverables & Contracts

The task delivers an optional db parameter on these helpers:

  • validate_and_create_buffer_data.
  • DatabaseMaxCounter.update_fsics.
  • DatabaseMaxCounter.calculate_filter_specific_instance_counters.
Acceptance Criteria
  • With a handle pinned to default2, buffer validation creates Buffer and RecordMaxCounterBuffer rows in default2 and updates records_transferred.
  • With a handle pinned to default2, the counter update writes DatabaseMaxCounter rows in default2.
  • On an empty default2, the counter calculation for a receiver in v2 format returns an empty result with sub and super keys.
  • No test above makes a query to default. The tests run with override_settings(DATABASE_ROUTERS=[]).
  • Callers that give no handle see today's behavior.
  • The characterization suite passes without edits.

Technical Pointers & Architecture

  • Target Components: morango/sync/utils.py:72 (validate_and_create_buffer_data; it reads transfer_session.sync_session.profile at :97 and calls transfer_session.save(...) at :147, and both must use the handle), morango/models/core.py:655 (update_fsics), :727 (calculate_filter_specific_instance_counters), and the queries at :690-705, :735, and :775.
  • Related Patterns: SyncDatabase from #365.
  • Data Model & Schema Considerations: None.
  • Resilience & Failure Modes: Validation errors keep their current types.

Notes & Tradeoffs

  • Dependencies: Blocked by: #366 (Dequeue transferred records into a chosen database). Blocks: #384.
  • Testing Requirements: The test app's TestingRouter sends instance saves and foreign-key reads to default, so tests with a pinned handle clear the routers (#362). This is a refactor. The characterization suite from #363 and #364 must pass without edits.
  • Tradeoffs & Alternatives Considered: Private functions take a required handle. Public helpers take an optional handle, so that host code keeps working.

Metadata

  • Complexity: Medium
  • Target Branch: release-v0.9.x

AI Usage

Drafted with Claude (Claude Code) from the approved design spec and implementation plan. The author reviewed the requirements, and the code references were checked against the release-v0.9.x codebase.

Lingua principale
Python
Stelle
15
Fork
23
Merge medio
4g 2h
PR unite (30g)
5

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di learningequality/morango

Tutte le issue di learningequality/morango

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.