Receiver helpers work against a chosen database
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 52/100
调研方向
Start with morango/sync/utils.py:72 and morango/models/core.py at update_fsics and calculate_filter_specific_instance_counters, then review the SyncDatabase pattern from #365. Run the characterization suites from #363 and #364 while checking the queries identified at core.py:690-705, 735, and 775. Done means the listed helpers honor an optional handle, pinned default2 tests avoid default, and existing callers and validation errors retain their behavior.
由索引模型根据 Issue 内容生成。
描述
Overview
This task (milestone M2) lets the public receiver helpers run against a database that the caller names. The helpers are buffer validation and the two counter (FSIC) functions.
Background & Motivation
The archive receives records the same way that a network server does. It validates incoming buffers, computes its counters, and updates its counters after dequeue. These helpers are public, and hosts call some of them. Thus each helper needs an optional database parameter. If a caller gives no database, the helper keeps the current behavior.
Design: spec. Plan: implementation plan, Task 6.
Description & Expected Outcomes
Each helper takes db=None. If the caller gives no handle, the helper uses the routed default handle, so existing callers see no change. If the caller gives a handle, all queries and writes in the helper go to that database.
The dequeue function from #366 passes its handle to the counter update.
Deliverables & Contracts
The task delivers an optional db parameter on these helpers:
validate_and_create_buffer_data.DatabaseMaxCounter.update_fsics.DatabaseMaxCounter.calculate_filter_specific_instance_counters.
Acceptance Criteria
- With a handle pinned to
default2, buffer validation createsBufferandRecordMaxCounterBufferrows indefault2and updatesrecords_transferred. - With a handle pinned to
default2, the counter update writesDatabaseMaxCounterrows indefault2. - On an empty
default2, the counter calculation for a receiver in v2 format returns an empty result withsubandsuperkeys. - No test above makes a query to
default. The tests run withoverride_settings(DATABASE_ROUTERS=[]). - Callers that give no handle see today's behavior.
- The characterization suite passes without edits.
Technical Pointers & Architecture
- Target Components:
morango/sync/utils.py:72(validate_and_create_buffer_data; it readstransfer_session.sync_session.profileat:97and callstransfer_session.save(...)at:147, and both must use the handle),morango/models/core.py:655(update_fsics),:727(calculate_filter_specific_instance_counters), and the queries at:690-705,:735, and:775. - Related Patterns:
SyncDatabasefrom #365. - Data Model & Schema Considerations: None.
- Resilience & Failure Modes: Validation errors keep their current types.
Notes & Tradeoffs
- Dependencies: Blocked by: #366 (Dequeue transferred records into a chosen database). Blocks: #384.
- Testing Requirements: The test app's
TestingRoutersends instance saves and foreign-key reads todefault, so tests with a pinned handle clear the routers (#362). This is a refactor. The characterization suite from #363 and #364 must pass without edits. - Tradeoffs & Alternatives Considered: Private functions take a required handle. Public helpers take an optional handle, so that host code keeps working.
Metadata
- Complexity: Medium
- Target Branch: release-v0.9.x
AI Usage
Drafted with Claude (Claude Code) from the approved design spec and implementation plan. The author reviewed the requirements, and the code references were checked against the release-v0.9.x codebase.
- 主要语言
- Python
- 星标
- 15
- 派生
- 23
- 平均合并
- 4 天 2 小时
- 30 天内合并 PR
- 5
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
learningequality/morango 的其他 Issue
-
DEV: dev-ops DEV: distributions DOCS: developer
难度 1/5 1-3 小时 新手友好度 78/100
learningequality/morango#387 ·
-
DEV: backend DEV: dev-ops TAG: unit tests
难度 2/5 1-3 小时 新手友好度 70/100
learningequality/morango#385 ·
-
DEV: backend P0 - critical TAG: tech update / debt TAG: unit tests
难度 2/5 1-3 小时 新手友好度 72/100
learningequality/morango#364 ·
-
dependencies DEV: dev-ops TAG: dependencies
难度 3/5 1-2 天 新手友好度 25/100
learningequality/morango#399 ·
-
Scope filters should list read-write partitions last可能已有人在做 @bjester 于 4 天前认领。 未关闭DEV: backend P0 - critical TAG: tech update / debt
learningequality/morango#398 · 已指派 1 人 ·
查看 learningequality/morango 的全部 Issue
相似的 Issue
-
bug P2 rust
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 72/100
jscott3201/rusty-bacnet#2085 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
evarness-ai/iris-harness#401 ·
-
难度 2/5 1-3 小时 新手友好度 76/100
sistemicorp/scripts#62 ·
-
area/mac help wanted needs-qa
难度 1/5 1 小时以内 新手友好度 76/100