Receiver helpers work against a chosen database
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 52/100
調査の方向性
Start with morango/sync/utils.py:72 and morango/models/core.py at update_fsics and calculate_filter_specific_instance_counters, then review the SyncDatabase pattern from #365. Run the characterization suites from #363 and #364 while checking the queries identified at core.py:690-705, 735, and 775. Done means the listed helpers honor an optional handle, pinned default2 tests avoid default, and existing callers and validation errors retain their behavior.
索引モデルが issue の本文から書いたものです。
説明
Overview
This task (milestone M2) lets the public receiver helpers run against a database that the caller names. The helpers are buffer validation and the two counter (FSIC) functions.
Background & Motivation
The archive receives records the same way that a network server does. It validates incoming buffers, computes its counters, and updates its counters after dequeue. These helpers are public, and hosts call some of them. Thus each helper needs an optional database parameter. If a caller gives no database, the helper keeps the current behavior.
Design: spec. Plan: implementation plan, Task 6.
Description & Expected Outcomes
Each helper takes db=None. If the caller gives no handle, the helper uses the routed default handle, so existing callers see no change. If the caller gives a handle, all queries and writes in the helper go to that database.
The dequeue function from #366 passes its handle to the counter update.
Deliverables & Contracts
The task delivers an optional db parameter on these helpers:
validate_and_create_buffer_data.DatabaseMaxCounter.update_fsics.DatabaseMaxCounter.calculate_filter_specific_instance_counters.
Acceptance Criteria
- With a handle pinned to
default2, buffer validation createsBufferandRecordMaxCounterBufferrows indefault2and updatesrecords_transferred. - With a handle pinned to
default2, the counter update writesDatabaseMaxCounterrows indefault2. - On an empty
default2, the counter calculation for a receiver in v2 format returns an empty result withsubandsuperkeys. - No test above makes a query to
default. The tests run withoverride_settings(DATABASE_ROUTERS=[]). - Callers that give no handle see today's behavior.
- The characterization suite passes without edits.
Technical Pointers & Architecture
- Target Components:
morango/sync/utils.py:72(validate_and_create_buffer_data; it readstransfer_session.sync_session.profileat:97and callstransfer_session.save(...)at:147, and both must use the handle),morango/models/core.py:655(update_fsics),:727(calculate_filter_specific_instance_counters), and the queries at:690-705,:735, and:775. - Related Patterns:
SyncDatabasefrom #365. - Data Model & Schema Considerations: None.
- Resilience & Failure Modes: Validation errors keep their current types.
Notes & Tradeoffs
- Dependencies: Blocked by: #366 (Dequeue transferred records into a chosen database). Blocks: #384.
- Testing Requirements: The test app's
TestingRoutersends instance saves and foreign-key reads todefault, so tests with a pinned handle clear the routers (#362). This is a refactor. The characterization suite from #363 and #364 must pass without edits. - Tradeoffs & Alternatives Considered: Private functions take a required handle. Public helpers take an optional handle, so that host code keeps working.
Metadata
- Complexity: Medium
- Target Branch: release-v0.9.x
AI Usage
Drafted with Claude (Claude Code) from the approved design spec and implementation plan. The author reviewed the requirements, and the code references were checked against the release-v0.9.x codebase.
- 主要言語
- Python
- スター
- 15
- フォーク
- 23
- 平均マージ
- 4日 2時間
- マージ済み PR（30日）
- 5
環境構築
- Dockerfile または Docker Compose ファイルあり
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
learningequality/morango のほかの issue
-
DEV: dev-ops DEV: distributions DOCS: developer
難易度 1/5 1〜3時間 初心者へのやさしさ 78/100
learningequality/morango#387 ·
-
DEV: backend DEV: dev-ops TAG: unit tests
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
learningequality/morango#385 ·
-
DEV: backend P0 - critical TAG: tech update / debt TAG: unit tests
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
learningequality/morango#364 ·
-
dependencies DEV: dev-ops TAG: dependencies
難易度 3/5 1〜2日 初心者へのやさしさ 25/100
learningequality/morango#399 ·
-
Scope filters should list read-write partitions last対応中かも @bjester が 4 日前に担当しました。 オープンDEV: backend P0 - critical TAG: tech update / debt
learningequality/morango#398 · 担当者 1 名 ·
learningequality/morango の issue をすべて見る
似ている issue
-
intake mcp-intake needs-ac needs-human-review priority:medium
難易度 2/5 1〜3時間 初心者へのやさしさ 67/100
Ikalus1988/MisakaNet#3848 · コメント 2 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 75/100
521xueweihan/HelloGitHub#4105 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
igormcsouza/bookloud#54 ·
-
難易度 1/5 1時間未満 初心者へのやさしさ 90/100
aws-samples/sample-per-model-bedrock#526 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
ok-oldking/ok-wuthering-waves#1802 ·
メンテナーはふだん 2 日以内に返信