Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Record manual stock changes in InventoryJournal

Aperta
  • Qualcosa non va?
#880 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp, mongodb
Ambito
backend, databases

Direzione di ricerca

Start with InventoryManageService and IInventoryManageService, then trace the listed stock-update paths in ProductViewModelService, BaseProductController, and the API command handlers. Review InventoryJournal and InventoryManageServiceTests before estimating how the shared adjustment flow fits. Done means all listed adjustment paths, notification behavior, no-op handling, and the specified tests meet the acceptance criteria.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

Problem

Manual stock changes leave no trace. InventoryJournal (src/Core/Grand.Domain/Catalog/InventoryJournal.cs) is written only for shipments: InventoryManageService.InsertInventoryJournal (src/Business/Grand.Business.Catalog/Services/Products/InventoryManageService.cs) is called with ObjectType = nameof(Shipment). When an administrator or an API client edits a quantity, the old value is simply overwritten, so there is no answer to "who changed this, when, from what to what, and why".

Code paths that change StockQuantity / ProductWarehouseInventory / combination stock without a journal entry:

  • Product edit - ProductViewModelService (src/Web/Grand.Web.AdminShared/Services/ProductViewModelService.cs): StockQuantity is mapped from the model on update, and SaveProductWarehouseInventory (~L439) writes per-warehouse StockQuantity and then sums to product.StockQuantity. Same flow for create (~L771) and update (~L830).
  • Bulk edit (grid) - same file, ~L1362-1367: product.StockQuantity = pModel.StockQuantity.
  • Attribute combinations - same file, ~L2200-2260: combination.StockQuantity, PrepareCombinationWarehouseInventory (per-warehouse ProductCombinationWarehouseInventory), and the recalculated product.StockQuantity. Also the "generate all combinations" path (BaseProductController, ~L2949 resets StockQuantity = 0).
  • Out-of-stock subscription notifications live in this view-model layer (OutOfStockNotifications, ~L189 and ~L223), so they only fire for panel edits.
  • Store owner and Vendor panels reuse the same AdminShared services/controllers, so they have the same gap.
  • Backend API (src/Modules/Grand.Module.Api):
    • PUT /Product and PATCH /Product/{key} -> UpdateProductCommandHandler maps StockQuantity from the DTO and calls UpdateProduct; it has its own, partial copy of the back-in-stock logic.
    • POST /Product/{key}/UpdateStock -> UpdateProductStockCommandHandler sets product.StockQuantity or the ProductWarehouseInventory row; it duplicates OutOfStockNotifications a third time.
    • ProductAttributeCombinationDto.StockQuantity is part of the DTO, so combination stock can change through product update as well.

Product import (ProductImportDataObject) also sets StockQuantity; it is a bulk path and is probably better handled as a follow-up.

The panels do not display InventoryJournal anywhere (no reference in Grand.Web.*); the collection is currently write-only from shipments and read nowhere.

Proposal

Add a core method to IInventoryManageService, for example:

Task AdjustStock(Product product, ProductAttributeCombination combination, string warehouseId,
    int newQuantity, string reason, string reference);

(or a delta-based overload). It should:

  • apply the new quantity to the product / warehouse row / combination (and its warehouse row), recompute the aggregates, and call UpdateStockProduct so LowStock / auto-unpublish keep working as today;
  • insert an InventoryJournal entry with a new ObjectType for manual adjustments (e.g. "StockAdjustment"), InQty / OutQty derived from the delta, ProductId, Attributes (combination), WarehouseId, Comments = reason, Reference = who/what (user e-mail, "api");
  • do nothing (no journal entry) when the quantity did not change;
  • own the out-of-stock subscription notifications: move OutOfStockNotifications from ProductViewModelService into core so the panel and every API path share one implementation, and delete the copies in the API handlers.

Route every path listed above through it: product edit and warehouse inventory, bulk edit, combination create/edit, API PUT/PATCH/UpdateStock.

Out of scope / follow-ups

  • A journal view per product in the admin panel (read side of InventoryJournal).
  • An optional "reason" field in the panel UI (until then Comments can be a default text such as "Manual adjustment").
  • Journal entries for product import.

Acceptance criteria

  • IInventoryManageService exposes a stock adjustment method covering product, warehouse and combination (+ combination warehouse) quantities.
  • Each adjustment writes one InventoryJournal entry with a dedicated ObjectType, correct InQty/OutQty, Comments and Reference.
  • Unchanged quantities produce no entry.
  • Admin, Store and Vendor product edit, bulk edit and combination edit go through the new method.
  • API PUT, PATCH and UpdateStock go through the new method; Reference identifies the API caller.
  • LowStock flag, auto-unpublish / out-of-stock behaviour and back-in-stock notifications behave as before, from a single implementation in core.
  • Unit tests in InventoryManageServiceTests cover product, warehouse and combination adjustments, no-op, and notification triggering.

Notes

  • Add an index on InventoryJournal (ProductId, CreateDateUtc) - needed as soon as a per-product view reads it.
  • No migration needed for existing data; history starts from the release that ships this.
Lingua principale
C#
Stelle
1.3k
Fork
549
Merge medio
8h 14m
PR unite (30g)
53

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di grandnode/grandnode2

Tutte le issue di grandnode/grandnode2

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.