Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Record manual stock changes in InventoryJournal

Abierto
  • ¿Algo no está bien?
#880 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
csharp, mongodb
Área
backend, databases

Línea de trabajo

Start with InventoryManageService and IInventoryManageService, then trace the listed stock-update paths in ProductViewModelService, BaseProductController, and the API command handlers. Review InventoryJournal and InventoryManageServiceTests before estimating how the shared adjustment flow fits. Done means all listed adjustment paths, notification behavior, no-op handling, and the specified tests meet the acceptance criteria.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

Problem

Manual stock changes leave no trace. InventoryJournal (src/Core/Grand.Domain/Catalog/InventoryJournal.cs) is written only for shipments: InventoryManageService.InsertInventoryJournal (src/Business/Grand.Business.Catalog/Services/Products/InventoryManageService.cs) is called with ObjectType = nameof(Shipment). When an administrator or an API client edits a quantity, the old value is simply overwritten, so there is no answer to "who changed this, when, from what to what, and why".

Code paths that change StockQuantity / ProductWarehouseInventory / combination stock without a journal entry:

  • Product edit - ProductViewModelService (src/Web/Grand.Web.AdminShared/Services/ProductViewModelService.cs): StockQuantity is mapped from the model on update, and SaveProductWarehouseInventory (~L439) writes per-warehouse StockQuantity and then sums to product.StockQuantity. Same flow for create (~L771) and update (~L830).
  • Bulk edit (grid) - same file, ~L1362-1367: product.StockQuantity = pModel.StockQuantity.
  • Attribute combinations - same file, ~L2200-2260: combination.StockQuantity, PrepareCombinationWarehouseInventory (per-warehouse ProductCombinationWarehouseInventory), and the recalculated product.StockQuantity. Also the "generate all combinations" path (BaseProductController, ~L2949 resets StockQuantity = 0).
  • Out-of-stock subscription notifications live in this view-model layer (OutOfStockNotifications, ~L189 and ~L223), so they only fire for panel edits.
  • Store owner and Vendor panels reuse the same AdminShared services/controllers, so they have the same gap.
  • Backend API (src/Modules/Grand.Module.Api):
    • PUT /Product and PATCH /Product/{key} -> UpdateProductCommandHandler maps StockQuantity from the DTO and calls UpdateProduct; it has its own, partial copy of the back-in-stock logic.
    • POST /Product/{key}/UpdateStock -> UpdateProductStockCommandHandler sets product.StockQuantity or the ProductWarehouseInventory row; it duplicates OutOfStockNotifications a third time.
    • ProductAttributeCombinationDto.StockQuantity is part of the DTO, so combination stock can change through product update as well.

Product import (ProductImportDataObject) also sets StockQuantity; it is a bulk path and is probably better handled as a follow-up.

The panels do not display InventoryJournal anywhere (no reference in Grand.Web.*); the collection is currently write-only from shipments and read nowhere.

Proposal

Add a core method to IInventoryManageService, for example:

Task AdjustStock(Product product, ProductAttributeCombination combination, string warehouseId,
    int newQuantity, string reason, string reference);

(or a delta-based overload). It should:

  • apply the new quantity to the product / warehouse row / combination (and its warehouse row), recompute the aggregates, and call UpdateStockProduct so LowStock / auto-unpublish keep working as today;
  • insert an InventoryJournal entry with a new ObjectType for manual adjustments (e.g. "StockAdjustment"), InQty / OutQty derived from the delta, ProductId, Attributes (combination), WarehouseId, Comments = reason, Reference = who/what (user e-mail, "api");
  • do nothing (no journal entry) when the quantity did not change;
  • own the out-of-stock subscription notifications: move OutOfStockNotifications from ProductViewModelService into core so the panel and every API path share one implementation, and delete the copies in the API handlers.

Route every path listed above through it: product edit and warehouse inventory, bulk edit, combination create/edit, API PUT/PATCH/UpdateStock.

Out of scope / follow-ups

  • A journal view per product in the admin panel (read side of InventoryJournal).
  • An optional "reason" field in the panel UI (until then Comments can be a default text such as "Manual adjustment").
  • Journal entries for product import.

Acceptance criteria

  • IInventoryManageService exposes a stock adjustment method covering product, warehouse and combination (+ combination warehouse) quantities.
  • Each adjustment writes one InventoryJournal entry with a dedicated ObjectType, correct InQty/OutQty, Comments and Reference.
  • Unchanged quantities produce no entry.
  • Admin, Store and Vendor product edit, bulk edit and combination edit go through the new method.
  • API PUT, PATCH and UpdateStock go through the new method; Reference identifies the API caller.
  • LowStock flag, auto-unpublish / out-of-stock behaviour and back-in-stock notifications behave as before, from a single implementation in core.
  • Unit tests in InventoryManageServiceTests cover product, warehouse and combination adjustments, no-op, and notification triggering.

Notes

  • Add an index on InventoryJournal (ProductId, CreateDateUtc) - needed as soon as a per-product view reads it.
  • No migration needed for existing data; history starts from the release that ships this.
Lenguaje dominante
C#
Estrellas
1.3k
Forks
549
Merge medio
7 h 58 min
PR fusionados (30 d)
52

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de grandnode/grandnode2

Todos los issues de grandnode/grandnode2

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.