Record manual stock changes in InventoryJournal
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
调研方向
Start with InventoryManageService and IInventoryManageService, then trace the listed stock-update paths in ProductViewModelService, BaseProductController, and the API command handlers. Review InventoryJournal and InventoryManageServiceTests before estimating how the shared adjustment flow fits. Done means all listed adjustment paths, notification behavior, no-op handling, and the specified tests meet the acceptance criteria.
由索引模型根据 Issue 内容生成。
描述
Problem
Manual stock changes leave no trace. InventoryJournal (src/Core/Grand.Domain/Catalog/InventoryJournal.cs) is written only for shipments: InventoryManageService.InsertInventoryJournal (src/Business/Grand.Business.Catalog/Services/Products/InventoryManageService.cs) is called with ObjectType = nameof(Shipment). When an administrator or an API client edits a quantity, the old value is simply overwritten, so there is no answer to "who changed this, when, from what to what, and why".
Code paths that change StockQuantity / ProductWarehouseInventory / combination stock without a journal entry:
- Product edit -
ProductViewModelService(src/Web/Grand.Web.AdminShared/Services/ProductViewModelService.cs):StockQuantityis mapped from the model on update, andSaveProductWarehouseInventory(~L439) writes per-warehouseStockQuantityand then sums toproduct.StockQuantity. Same flow for create (~L771) and update (~L830). - Bulk edit (grid) - same file, ~L1362-1367:
product.StockQuantity = pModel.StockQuantity. - Attribute combinations - same file, ~L2200-2260:
combination.StockQuantity,PrepareCombinationWarehouseInventory(per-warehouseProductCombinationWarehouseInventory), and the recalculatedproduct.StockQuantity. Also the "generate all combinations" path (BaseProductController, ~L2949 resetsStockQuantity = 0). - Out-of-stock subscription notifications live in this view-model layer (
OutOfStockNotifications, ~L189 and ~L223), so they only fire for panel edits. - Store owner and Vendor panels reuse the same AdminShared services/controllers, so they have the same gap.
- Backend API (
src/Modules/Grand.Module.Api):PUT /ProductandPATCH /Product/{key}->UpdateProductCommandHandlermapsStockQuantityfrom the DTO and callsUpdateProduct; it has its own, partial copy of the back-in-stock logic.POST /Product/{key}/UpdateStock->UpdateProductStockCommandHandlersetsproduct.StockQuantityor theProductWarehouseInventoryrow; it duplicatesOutOfStockNotificationsa third time.ProductAttributeCombinationDto.StockQuantityis part of the DTO, so combination stock can change through product update as well.
Product import (ProductImportDataObject) also sets StockQuantity; it is a bulk path and is probably better handled as a follow-up.
The panels do not display InventoryJournal anywhere (no reference in Grand.Web.*); the collection is currently write-only from shipments and read nowhere.
Proposal
Add a core method to IInventoryManageService, for example:
Task AdjustStock(Product product, ProductAttributeCombination combination, string warehouseId,
int newQuantity, string reason, string reference);
(or a delta-based overload). It should:
- apply the new quantity to the product / warehouse row / combination (and its warehouse row), recompute the aggregates, and call
UpdateStockProductso LowStock / auto-unpublish keep working as today; - insert an
InventoryJournalentry with a newObjectTypefor manual adjustments (e.g."StockAdjustment"),InQty/OutQtyderived from the delta,ProductId,Attributes(combination),WarehouseId,Comments = reason,Reference = who/what(user e-mail,"api"); - do nothing (no journal entry) when the quantity did not change;
- own the out-of-stock subscription notifications: move
OutOfStockNotificationsfromProductViewModelServiceinto core so the panel and every API path share one implementation, and delete the copies in the API handlers.
Route every path listed above through it: product edit and warehouse inventory, bulk edit, combination create/edit, API PUT/PATCH/UpdateStock.
Out of scope / follow-ups
- A journal view per product in the admin panel (read side of
InventoryJournal). - An optional "reason" field in the panel UI (until then
Commentscan be a default text such as "Manual adjustment"). - Journal entries for product import.
Acceptance criteria
-
IInventoryManageServiceexposes a stock adjustment method covering product, warehouse and combination (+ combination warehouse) quantities. - Each adjustment writes one
InventoryJournalentry with a dedicatedObjectType, correctInQty/OutQty,CommentsandReference. - Unchanged quantities produce no entry.
- Admin, Store and Vendor product edit, bulk edit and combination edit go through the new method.
- API
PUT,PATCHandUpdateStockgo through the new method;Referenceidentifies the API caller. - LowStock flag, auto-unpublish / out-of-stock behaviour and back-in-stock notifications behave as before, from a single implementation in core.
- Unit tests in
InventoryManageServiceTestscover product, warehouse and combination adjustments, no-op, and notification triggering.
Notes
- Add an index on
InventoryJournal(ProductId,CreateDateUtc) - needed as soon as a per-product view reads it. - No migration needed for existing data; history starts from the release that ships this.
- 主要语言
- C#
- 星标
- 1.3k
- 派生
- 549
- 平均合并
- 7 小时 58 分钟
- 30 天内合并 PR
- 52
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
grandnode/grandnode2 的其他 Issue
-
HTML sitemap lists unpublished pages可能已有人在做 @KrzysztofPajak 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
grandnode/grandnode2#883 ·
维护者通常 1 天内回复
-
bug
难度 3/5 1-2 天 新手友好度 65/100
grandnode/grandnode2#881 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 25/100
grandnode/grandnode2#849 ·
维护者通常 1 天内回复
-
grandnode/grandnode2#499 ·
维护者通常 1 天内回复
-
grandnode/grandnode2#410 ·
维护者通常 1 天内回复
查看 grandnode/grandnode2 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
microsoft/fluentui-blazor#5410 ·
维护者通常 1 天内回复
-
Bug pulumi/pulumi
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
activescott/lessmsi#306 ·
-
Docs MSBuild
难度 2/5 1-3 小时 新手友好度 68/100
getsentry/sentry-dotnet#5691 · 1 条评论 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复