Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Please add the offer system

Aperta
  • Qualcosa non va?
#849 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
csharp, mongodb
Ambito
backend

Direzione di ricerca

Read the catalog model around Product fields VendorId, Sku, StockQuantity and Price, then trace how IPricingService uses Product. Compare ProductAttributeCombination, OrderItem, Vendor, InventoryJournal and ShoppingCartItem to understand the proposed design. This issue asks whether shared-catalog offers are in scope and explicitly does not commit to implementation; done means maintainers decide whether one-product-one-vendor is a deliberate boundary.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Shared catalog: can multiple vendors sell the same product?

I evaluated GrandNode2 for a marketplace project and read through the catalog domain model. One question I couldn't settle from the code, so I'd rather ask than assume.

Observation

Product carries the seller, price and stock on a single document — VendorId (line 82), Sku (147), StockQuantity (335), Price (431) — and IPricingService takes Product as the price-bearing entity throughout. One catalog record therefore belongs to one vendor.

That supports a marketplace where each vendor owns their own listings. It doesn't support a shared catalog, where several vendors compete on the same record and the storefront selects a winning offer — Amazon's buy box, Google Shopping. Under the current model, two vendors selling the same title produce two products, two URLs and two sets of reviews.

What already exists

Several pieces are in place. ProductAttributeCombination already models SKU, price and stock as a unit hanging off a product; it simply doesn't carry a VendorId. OrderItem already has VendorId and Commission. Vendor already has the rating aggregates a ranking would need. InventoryJournal is already polymorphic over ObjectType.

The gap appears to be one entity — an Offer holding vendor, product, price, stock and status — plus a selection service, and an OfferId on ShoppingCartItem so the cart remembers which vendor the customer chose.

On compatibility

This could be additive. If an offer service synthesises an implicit offer from the product when no explicit ones exist, an installation with zero offer rows behaves exactly as it does today: no migration, no setting change, no rewrite.

Question

Is a shared-catalog marketplace in scope for GrandNode2, or is one-product-one-vendor a deliberate boundary? Either answer is useful — if it's out of scope, I'll close this.

Happy to expand on any of the above. I can't commit to implementing it, so please treat this as a design question rather than a proposal of work.

Lingua principale
C#
Stelle
1.3k
Fork
549
Merge medio
8h 14m
PR unite (30g)
53

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di grandnode/grandnode2

Tutte le issue di grandnode/grandnode2

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.