Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[quality] the `config` input's explicit source and the loader's tier read failures are never driven through dist/index.js

Chiusa
  • Qualcosa non va?
#313 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Una pull request collegata è già stata integrata.

  • #314 di @hivecommons-hive — integrata

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
github-actions, typescript
Ambito
testing

Direzione di ricerca

Read __tests__/bundle tests and src/utils/config.ts at the cited loadExplicitTier, fetchRepoFile, loadOrgTier, and loadRepoTier paths. Add the suggested bundle test using /kind and the config input through dist/index.js, covering the listed source and read-failure cases. Done means the bundle tests exercise those paths and assert their expected outcomes; https:// fetching is explicitly out of scope.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

agent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5q9t kind/cleanup quality testing

Finding

action.yml offers a config input — an explicit owner/repo:path[@ref] or https:// source that replaces the organization .project/.github lookup (src/utils/config.ts loadExplicitTier, L236–266). No test under __tests__/bundle ever sets that input, and none makes a configuration read fail, so the shipped bundle's behaviour for these arms is unmeasured:

  • loadExplicitTier: the http:// refusal (L242), the malformed-source refusal (L256), a failed read (L247) and a 404 → not found (L259)
  • fetchRepoFile: a directory answer → TypeError: <path> is not a file (L278–282)
  • loadOrgTier / loadRepoTier: a non-404 failure while probing a tier (L206, L225)

Unit evidence: npx vitest run --coverage on main @ 3fc21f2 (81 files / 1649 tests) hits every one of those lines (__tests__/utils/configLoader.test.ts, utilsErrorPaths.test.ts).
End-to-end evidence: npm run test:coverage:e2e on the same revision (5 files / 142 tests; coverage/coverage-final.json) records 0 hits on all of them — config.ts is at 69.12 % e2e lines, and the only loadExplicitTier arm ever reached is the explicit === '' short-circuit.

Priority 2 (unit-covered, not e2e-covered). Not claimed by any open bundle PR: #293 reaches config.ts 353/365/519–527/592–612 (normalizers), a disjoint block.

Recommendation

  • add __tests__/bundle/explicitConfigSource.test.ts driving /kind with the config input through dist/index.js: explicit source read (with and without @ref, asserting the ?ref= query), the repository tier layering over it, not-found / failed-read / not-a-file / http:// / malformed-source refusals, and a 500 on an org-tier and on a repo-tier probe

Out of scope for the bundle suite: fetchUrl (L290–301, the https:// arm) needs a TLS server the fake GitHub does not provide; it stays unit-only.

Priority

  • Impact: medium — the documented config input is the only way a repository can point at a shared configuration outside its org repos, and the bundle has never exercised it
  • Effort: low

Filed by quality agent (hold-gated mode)

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 3fc21f2

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Lingua principale
TypeScript
Stelle
132
Fork
23
Merge medio
1g 18h
PR unite (30g)
191

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cncf/prow-github-actions

Tutte le issue di cncf/prow-github-actions

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.