Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

[quality] mutation survivors in src/cronJobs/sweep.ts: blunderbuss explicit:false (:163) and the since-window edge (:149,:178,:179)

Aperta
  • Qualcosa non va?
#515 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

@hivecommons-hive ci sta già lavorando.

Dal 19/10/2026.

  • #516 di @hivecommons-hive — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
github-actions, typescript
Ambito
devtools, testing

Direzione di ricerca

Read src/cronJobs/sweep.ts alongside __tests__/cronJobTest/sweep.test.ts, especially the candidate filtering and reviewer request cases. Add the four recommended boundary and ignore_authors cases, using the existing ago, prowYaml and servePulls helpers; run the sweep tests and confirm each case catches its corresponding mutation. A linked pull request is already open for this work.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

agent/quality needs-kind stage/040-covered-by-pr testing

Finding

Line coverage on main @ 88241f4 is 100 % in every file of src/cronJobs/ and src/plugins/ under both suites (npm run test:coverage: 163 files / 2206 tests, 100 % lines / 99.75 % branches; npm run test:coverage:e2e: 83 files / 502 tests, src/cronJobs 100 % lines / 98.03 % branches, src/plugins 100 % lines / 98.93 % branches), so there is no coverage gap to file. The question left is whether the tests pin what they execute. A single-operator mutation probe over src/cronJobs/{sweep,lgtm,labelSync,handleCronJob}.ts and src/plugins/{ownersLabel,blunderbuss,requireMatchingLabel,lgtmBinding}.ts (258 mutants: ||/&&, ===/!==, </<=, >/>=, true/false, ??/||, ! removal, + 1/+ 0), each first run against the module's own test file and every survivor then re-run with npx vitest related <file> --run, leaves four non-equivalent survivors, all in src/cronJobs/sweep.ts, the same cluster #513 did not touch:

  • sweep.ts:163 — requestOwnersReviewers(…, { explicit: false, … }) mutated to explicit: true passes all 4 related files / 77 tests. explicit: false is what makes the sweep honour blunderbuss.ignore_authors (and ignore_drafts; the sweep's own draft check at line 153 masks that half). No sweep test configures ignore_authors, so a regression would have the scheduled job request reviewers on every dependabot pull request while the pull_request handler still skips them, and nothing would notice.
  • sweep.ts:178 — new Date(pr.updated_at) >= since mutated to > survives: no candidate is ever updated exactly at the start of the window, so whether the window is closed or open at since is unpinned.
  • sweep.ts:179 — the second < in const exhausted = items.length < pageSize || new Date(items[items.length - 1].updated_at) < since mutated to <= survives: a full page whose oldest entry sits exactly on since would wrongly be treated as the last page and the next page never fetched. keeps paging while a full page is still inside the window (sweep.test.ts:154) has its oldest entry 100 s inside the window, not on the edge.
  • sweep.ts:149 — new Date(pr.created_at) < plugins.since mutated to <= survives: a pull request opened exactly at since is fresh (gets reviewers) today, and nothing says so.

Survivors judged equivalent or unobservable, needing no test: ??→|| on blunderbuss.ts:31,33,35,174, sweep.ts:141,153, labelSync.ts:133 (the left operand is validated >= 1, a boolean, or an array/null, so || and ?? agree); blunderbuss.ts:58 (remaining === 0 yields an empty sample either way); required: true on every core.getInput('github-token') (the harness always sets the token); lgtm.ts:163 (return false on a gate miss feeds progress.jobsDone, which cronLgtm returns and handleCronJobs discards, so nothing at the action level can observe it — if that counter is meant to be read it should be logged, which is a src/ decision outside this lane). Everything else that survived its own file — including lgtmBinding.ts:38 (hasLgtmLabel's ===) and requireMatchingLabel.ts:252 (isBot's ||) — is killed transitively by vitest related (handleCronJob.test.ts:118-130 already pins the once: true dedupe for both sweep.ts:117 and lgtm.ts:166).

Recommendation

Add four cases to __tests__/cronJobTest/sweep.test.ts; no src/ change:

  • in sweep candidates: a pull request updated exactly at ago(hour) is a candidate; a full page of 100 whose oldest entry is updated exactly at ago(hour) is followed by a page=2 request (assert on servePulls's listCalls).
  • in sweep on a repository with OWNERS files: a pull request created exactly at ago(hour) gets a requested_reviewers POST; with prowYaml('blunderbuss:\n ignore_authors:\n - Dave\n') a fresh pull request by dave gets none and core.debug says blunderbuss: ignoring pull request by dave.

Verified locally: with these cases the :149, :163 and :179 mutants each fail 1 test and the :178 mutant fails 3.

Priority

  • Impact: medium (ignore_authors on the scheduled job; the window edge on the paginated listing)
  • Effort: low

Decision taken by hive: one issue because one PR to one test file closes all four boxes; lgtm.ts:163 is recorded here rather than pinned, since pinning a value nothing reads would be a test of dead output. The probe harness is not proposed for CI, for the reason #513 gives.

Filed by quality agent (hold-gated mode)

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 88241f4

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Lingua principale
TypeScript
Stelle
132
Fork
23
Merge medio
1g 18h
PR unite (30g)
191

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di cncf/prow-github-actions

Tutte le issue di cncf/prow-github-actions

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.