[quality] the `config` input's explicit source and the loader's tier read failures are never driven through dist/index.js
维护者通常 1 天内回复
已经有一个关联 PR 被合并了。
- #314 来自 @hivecommons-hive —— 已合并
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 25/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 停滞
- 技术栈
- github-actions, typescript
- 领域
- testing
调研方向
Read __tests__/bundle tests and src/utils/config.ts at the cited loadExplicitTier, fetchRepoFile, loadOrgTier, and loadRepoTier paths. Add the suggested bundle test using /kind and the config input through dist/index.js, covering the listed source and read-failure cases. Done means the bundle tests exercise those paths and assert their expected outcomes; https:// fetching is explicitly out of scope.
由索引模型根据 Issue 内容生成。
描述
Finding
action.yml offers a config input — an explicit owner/repo:path[@ref] or https:// source that replaces the organization .project/.github lookup (src/utils/config.ts loadExplicitTier, L236–266). No test under __tests__/bundle ever sets that input, and none makes a configuration read fail, so the shipped bundle's behaviour for these arms is unmeasured:
loadExplicitTier: thehttp://refusal (L242), the malformed-source refusal (L256), a failed read (L247) and a 404 →not found(L259)fetchRepoFile: a directory answer →TypeError: <path> is not a file(L278–282)loadOrgTier/loadRepoTier: a non-404 failure while probing a tier (L206, L225)
Unit evidence: npx vitest run --coverage on main @ 3fc21f2 (81 files / 1649 tests) hits every one of those lines (__tests__/utils/configLoader.test.ts, utilsErrorPaths.test.ts).
End-to-end evidence: npm run test:coverage:e2e on the same revision (5 files / 142 tests; coverage/coverage-final.json) records 0 hits on all of them — config.ts is at 69.12 % e2e lines, and the only loadExplicitTier arm ever reached is the explicit === '' short-circuit.
Priority 2 (unit-covered, not e2e-covered). Not claimed by any open bundle PR: #293 reaches config.ts 353/365/519–527/592–612 (normalizers), a disjoint block.
Recommendation
- add
__tests__/bundle/explicitConfigSource.test.tsdriving/kindwith theconfiginput throughdist/index.js: explicit source read (with and without@ref, asserting the?ref=query), the repository tier layering over it, not-found / failed-read / not-a-file /http:/// malformed-source refusals, and a 500 on an org-tier and on a repo-tier probe
Out of scope for the bundle suite: fetchUrl (L290–301, the https:// arm) needs a TLS server the fake GitHub does not provide; it stays unit-only.
Priority
- Impact: medium — the documented
configinput is the only way a repository can point at a shared configuration outside its org repos, and the bundle has never exercised it - Effort: low
Filed by quality agent (hold-gated mode)
🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 3fc21f2
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88
- 主要语言
- TypeScript
- 星标
- 132
- 派生
- 24
- 平均合并
- 1 天 6 小时
- 30 天内合并 PR
- 240
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
cncf/prow-github-actions 的其他 Issue
-
hive/advisory kind/cleanup
难度 5/5 一周以上 新手友好度 15/100
cncf/prow-github-actions#170 · 9 条评论 ·
维护者通常 1 天内回复
查看 cncf/prow-github-actions 的全部 Issue
相似的 Issue
-
triage
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
🎙️ task - drop the raw `./node_modules/.bin/rhachet roles boot` line from bhuild's feedback template未关闭
难度 2/5 1-3 小时 新手友好度 62/100
ehmpathy/rhachet-roles-bhuild#639 ·
维护者通常 1 天内回复
-
e2e-failure ready-to-code
难度 2/5 1-3 小时 新手友好度 70/100
redhat-developer/rhdh-plugin-export-overlays#4650 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 13 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
omdsh-dev/DSH-better-sidebar#1098 ·
维护者通常 2 天内回复