[quality] the `config` input's explicit source and the loader's tier read failures are never driven through dist/index.js
Los mantenedores suelen responder en 2 días
Ya se ha fusionado un pull request relacionado.
- #314 de @hivecommons-hive — fusionado
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Estancado
- Stack tecnológico
- github-actions, typescript
- Área
- testing
Línea de trabajo
Read __tests__/bundle tests and src/utils/config.ts at the cited loadExplicitTier, fetchRepoFile, loadOrgTier, and loadRepoTier paths. Add the suggested bundle test using /kind and the config input through dist/index.js, covering the listed source and read-failure cases. Done means the bundle tests exercise those paths and assert their expected outcomes; https:// fetching is explicitly out of scope.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Finding
action.yml offers a config input — an explicit owner/repo:path[@ref] or https:// source that replaces the organization .project/.github lookup (src/utils/config.ts loadExplicitTier, L236–266). No test under __tests__/bundle ever sets that input, and none makes a configuration read fail, so the shipped bundle's behaviour for these arms is unmeasured:
loadExplicitTier: thehttp://refusal (L242), the malformed-source refusal (L256), a failed read (L247) and a 404 →not found(L259)fetchRepoFile: a directory answer →TypeError: <path> is not a file(L278–282)loadOrgTier/loadRepoTier: a non-404 failure while probing a tier (L206, L225)
Unit evidence: npx vitest run --coverage on main @ 3fc21f2 (81 files / 1649 tests) hits every one of those lines (__tests__/utils/configLoader.test.ts, utilsErrorPaths.test.ts).
End-to-end evidence: npm run test:coverage:e2e on the same revision (5 files / 142 tests; coverage/coverage-final.json) records 0 hits on all of them — config.ts is at 69.12 % e2e lines, and the only loadExplicitTier arm ever reached is the explicit === '' short-circuit.
Priority 2 (unit-covered, not e2e-covered). Not claimed by any open bundle PR: #293 reaches config.ts 353/365/519–527/592–612 (normalizers), a disjoint block.
Recommendation
- add
__tests__/bundle/explicitConfigSource.test.tsdriving/kindwith theconfiginput throughdist/index.js: explicit source read (with and without@ref, asserting the?ref=query), the repository tier layering over it, not-found / failed-read / not-a-file /http:/// malformed-source refusals, and a 500 on an org-tier and on a repo-tier probe
Out of scope for the bundle suite: fetchUrl (L290–301, the https:// arm) needs a TLS server the fake GitHub does not provide; it stays unit-only.
Priority
- Impact: medium — the documented
configinput is the only way a repository can point at a shared configuration outside its org repos, and the bundle has never exercised it - Effort: low
Filed by quality agent (hold-gated mode)
🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 3fc21f2
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88
- Lenguaje dominante
- TypeScript
- Estrellas
- 132
- Forks
- 24
- Merge medio
- 1 d 18 h
- PR fusionados (30 d)
- 191
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de cncf/prow-github-actions
-
[quality] prefixed.ts: /stage and /status exclusive replacement, two-value /remove-lifecycle, mixed-case allowlist values and the first protected offender survive mutationPosiblemente ocupada @hivecommons-hive la tomó hace 1 día. Abiertoagent/quality needs-kind stage/040-covered-by-pr testing
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
cncf/prow-github-actions#538 · 1 comentario ·
Los mantenedores suelen responder en 2 días
-
[quality] approveReview.ts: a PAT that is not the author never has its review submission asserted, and withdrawalReason's five-file bound, lgtm skip, user casing and withdrawer order are unpinnedPosiblemente ocupada @hivecommons-hive la tomó hace 2 días. Abiertoagent/quality needs-kind stage/040-covered-by-pr testing
Dificultad 2/5 1-3 horas Aptitud para principiantes 83/100
cncf/prow-github-actions#526 · 1 comentario ·
Los mantenedores suelen responder en 2 días
-
[quality] trigger.ts: /test matches workflow names and paths case-insensitively, /ok-to-test honours an existing label in any case, and the non-PR arm of /test and /ok-to-test leaves the run green — none of it is assertedPosiblemente ocupada @hivecommons-hive la tomó hace 2 días. Abiertoagent/quality needs-kind stage/040-covered-by-pr testing
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
cncf/prow-github-actions#523 · 6 comentarios ·
Los mantenedores suelen responder en 2 días
-
[quality] approve.ts: ten mutation survivors — any-Bot /approve, user-token bot review, require_self_approval break, approver sort, label casing, isBot notifier matchPosiblemente ocupada @hivecommons-hive la tomó hace 2 días. Abiertoagent/quality needs-kind stage/040-covered-by-pr testing
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
cncf/prow-github-actions#521 · 2 comentarios ·
Los mantenedores suelen responder en 2 días
-
[quality] mutation survivors in src/plugins/requireMatchingLabel.ts: the withGracePeriod default, the graceMs > 0 guard, isBot's || and the no-rule debug text are not pinned by any testPosiblemente ocupada @hivecommons-hive la tomó hace 2 días. Abiertoagent/quality needs-kind stage/040-covered-by-pr testing
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
cncf/prow-github-actions#519 · 1 comentario ·
Los mantenedores suelen responder en 2 días
Todos los issues de cncf/prow-github-actions
Issues similares
-
bug P3 UI/UX
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
StellarState/SS-backend#712 ·
Los mantenedores suelen responder en 1 día
-
area: backend bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
snapotter-hq/SnapOtter#3473 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
gitroomhq/postiz-app#2304 ·
Los mantenedores suelen responder en 1 día
-
Resolve CI maintenance findingsAbiertoharlan-agent-ready-to-implement routine:ci-review
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
harlan-zw/unlighthouse#454 · 2 comentarios ·
Los mantenedores suelen responder en 1 día