OpenAIConverseConverter restores an empty history when one blob or text payload fails to parse
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Idoneità per principianti
- 82/100
Direzione di ricerca
Inizia in src/bedrock_agentcore/memory/integrations/strands/converters/openai.py, a OpenAIConverseConverter.events_to_messages (L159-L186), e leggi session_manager.py L795-L814 per capire perché un'eccezione che sfugge svuota la cronologia. Esegui la riproduzione dell'issue con MemoryClient mockato per confermare le tre forme che falliscono, poi rispecchia la gestione di #749 in AgentCoreMemoryConverter: salta il payload non valido e registra solo l'id dell'evento. Fatto quando un evento non parseable viene saltato e la cronologia valida viene ancora restituita; aggiungi copertura accanto ai test esistenti del converter.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Hi team, hope you're doing well!
This is a follow up from #743, where @kimnamu spotted it while testing #749. Thank you, @kimnamu!
Describe the bug
With converter=OpenAIConverseConverter, one stored event that the converter can't parse makes AgentCoreMemorySessionManager.list_messages return [], so the restored agent starts with no history, valid messages included. Three shapes trigger it on current main:
- a dict blob, the shape in
create_blob_event's docstring example (client.py L589 to L596) - the blob
"[3, 4]" - deeply nested conversational text
#749 fixes the same kind of gap in AgentCoreMemoryConverter but doesn't touch converters/openai.py, so the branch behaves the same as main here.
To Reproduce
list_messagespasses every listed event toself.converter.events_to_messagesand catches any exception by logging it and returning[](session_manager.py L795 to L814).- In
OpenAIConverseConverter.events_to_messages(converters/openai.py L159 to L186):- a dict blob reaches
json.loads(payload_item["blob"]), which raisesTypeError, and the blobexceptonly catches(json.JSONDecodeError, ValueError) "[3, 4]"passes the list of length 2 check, thenjson.loads(blob_data[0])gets3and raisesTypeError- deeply nested text makes
json.loads(conv["content"]["text"])raiseRecursionError, which the conversationalexcept (json.JSONDecodeError, KeyError, ValueError)doesn't catch
- a dict blob reaches
- The exception escapes
events_to_messages,list_messagesreturns[], and the agent starts with an empty history.
Minimal repro
Mocked MemoryClient, no AWS needed. Tested on main at 8467c9a (1.27.0) with strands-agents 1.56.0:
import json
from unittest.mock import patch
from bedrock_agentcore.memory.integrations.strands.config import AgentCoreMemoryConfig
from bedrock_agentcore.memory.integrations.strands.converters.openai import OpenAIConverseConverter
from bedrock_agentcore.memory.integrations.strands.session_manager import AgentCoreMemorySessionManager
def stored(role, text):
return {"payload": [{"conversational": {"role": role.upper(), "content": {"text": json.dumps({"role": role, "content": text})}}}]}
config = AgentCoreMemoryConfig(memory_id="mem", session_id="sess", actor_id="actor")
with patch("bedrock_agentcore.memory.integrations.strands.session_manager.MemoryClient") as client, patch("boto3.Session"):
client.return_value.list_events.return_value = []
manager = AgentCoreMemorySessionManager(config, converter=OpenAIConverseConverter)
history = [stored("assistant", "hi there"), stored("user", "hello")]
odd = {
"dict blob": {"payload": [{"blob": {"note": "x"}}]},
"blob [3, 4]": {"payload": [{"blob": "[3, 4]"}]},
"deeply nested text": {"payload": [{"conversational": {"role": "USER", "content": {"text": "[" * 100000 + "]" * 100000}}}]},
}
manager.memory_client.list_events.return_value = history
print("valid events only:", len(manager.list_messages("sess", "agent")))
for name, event in odd.items():
manager.memory_client.list_events.return_value = [event] + history
print(f"plus one {name}:", len(manager.list_messages("sess", "agent")))
Output:
valid events only: 2
Failed to list messages from AgentCore Memory: the JSON object must be str, bytes or bytearray, not dict
plus one dict blob: 0
Failed to list messages from AgentCore Memory: the JSON object must be str, bytes or bytearray, not int
plus one blob [3, 4]: 0
Failed to list messages from AgentCore Memory: maximum recursion depth exceeded while decoding a JSON array from a unicode string
plus one deeply nested text: 0
Expected behavior
The one payload that can't be parsed gets skipped with a log line, and the rest of the history is restored, the same way the converter already skips a conversational payload that isn't JSON.
Related: blob content in the ERROR log
The blob except logs the whole payload: logger.error("Failed to parse blob payload: %s", payload_item) (converters/openai.py L177). Once TypeError is caught there, dict blobs land on that line and their content goes into the ERROR log. #749 switched the matching line in AgentCoreMemoryConverter to log only the event id, logger.error("Failed to parse blob content in event %s", event.get("eventId")), and the same would work here.
Environment
- bedrock-agentcore: main at 8467c9a (1.27.0)
- strands-agents: 1.56.0
- Python 3.10, macOS
Additional context
A possible fix: catch TypeError and RecursionError in both branches, log only the event id, and continue, mirroring #749. Does that sound right to you, or would you rather handle it differently? I'm happy to send a PR, or fold it into #749 if you'd prefer both converters in one place. Thanks so much!
- Lingua principale
- Python
- Stelle
- 786
- Fork
- 163
- Merge medio
- 4h
- PR unite (30g)
- 22
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di aws/bedrock-agentcore-sdk-python
-
bug high-severity
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
aws/bedrock-agentcore-sdk-python#752 ·
I maintainer di solito rispondono entro 1 giorno
-
delete_all_long_term_memories_in_namespace deletes only the first 10 recordsForse già presa @Fire162 l’ha presa 18 giorni fa. Apertabug high-severity
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
aws/bedrock-agentcore-sdk-python#727 ·
I maintainer di solito rispondono entro 1 giorno
-
MPP: credential is always sent in Authorization, ignoring header="Payment-Authorization" in the challengeForse già presa @abhiramshaji-cyber l’ha presa 24 giorni fa. Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
aws/bedrock-agentcore-sdk-python#702 ·
I maintainer di solito rispondono entro 1 giorno
-
[Bug] update_message fails with parameter validation error when SessionMessage.message_id is a Strands positional integer indexForse già presa @citizen204 l’ha presa 144 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
aws/bedrock-agentcore-sdk-python#556 ·
I maintainer di solito rispondono entro 1 giorno
-
CodeInterpreter should not require a region argumentForse già presa @citizen204 l’ha presa 159 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
aws/bedrock-agentcore-sdk-python#511 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di aws/bedrock-agentcore-sdk-python
Issue simili
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
snap-stanford/Biomni#380 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
microsoft/playwright-python#3361 ·
I maintainer di solito rispondono entro 1 giorno
-
documentation priority: low size: S status: needs triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
cubrid-lab/sqlalchemy-cubrid#1397 ·
I maintainer di solito rispondono entro 1 giorno
-
documentation priority: low size: S status: needs triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
cubrid-lab/pycubrid#1307 ·
I maintainer di solito rispondono entro 1 giorno
-
[Bug]: Installer hides SSL certificate errors as bare URLError, and the suggested fix can't workApertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
ShaftHQ/chaosengine-harness#143 ·
I maintainer di solito rispondono entro 1 giorno