fix: My Sites, Limits and Current Membership columns above 3 collapse to one column (missing grid utilities)
I maintainer di solito rispondono entro 1 giorno
Valutazione
Questa issue non è ancora stata valutata.
Descrizione
What
The columns setting on the My Sites, Limits & Quotas and Current Membership elements builds a utility class from the chosen number (wu-grid-cols-N, sm:wu-grid-cols-N, lg:wu-grid-cols-N, xl:wu-grid-cols-N). assets/css/framework.css only defines some of them. Where the class is missing, the grid has a single column.
With the default columns=4, My Sites shows four columns only from 1280px up and a single column at 1024px and 768px. columns=5 is always a single column. The block-editor preview shows the same single column, because its canvas is narrower than 1280px.
Evidence
Measured on a published account page ([wu_my_sites], default columns=4), by reading the computed grid-template-columns of the grid container:
| Viewport | Grid columns |
|---|---|
| 1440px | 4 |
| 1280px | 4 |
| 1024px | 1 |
| 768px | 1 |
The classes on the element are wu-grid-cols-4 sm:wu-grid-cols-4 xl:wu-grid-cols-4. Only the xl: rule exists for 4.
Utilities that exist today in assets/css/framework.css:
| Variant | Defined for N | Lines |
|---|---|---|
| base | 1, 2, 3 | 667-673 |
sm: |
2, 3, 12 | 1696-1702 |
md: |
2, 3, 4, 5, 6 | 1866-1878 |
lg: |
3, 4 | 1947-1950 |
xl: |
3, 4 | 1959-1962 |
Templates that build the class from a setting:
views/dashboard-widgets/my-sites.php:31: base,sm:andxl:;columnsis 1 to 5 (inc/ui/class-my-sites-element.php:177).views/dashboard-widgets/limits-and-quotas.php:30:lg:;columnsis 1 to 10 (inc/ui/class-limits-element.php:137).views/dashboard-widgets/current-membership.php:116:sm:;columnsis 1 to 5 (inc/ui/class-current-membership-element.php:192).views/checkout/templates/template-selection/clean.php:88andlegacy.php:175:md:, which is fully covered today.
None of this changed in the account work (#2133). It is on main.
Files to modify
assets/css/framework.cssand the regeneratedassets/css/framework.min.css(runpnpm run cleancss; the PR build checks the minified file is current).- Possibly the three dashboard-widget templates above, if the responsive pattern is changed rather than the utilities added.
Files Scope
assets/css/framework.cssassets/css/framework.min.cssviews/dashboard-widgets/my-sites.phpviews/dashboard-widgets/limits-and-quotas.phpviews/dashboard-widgets/current-membership.php
Reference pattern
The existing rules, for example framework.css:667 and framework.css:1866:
.wu-styling :is(.wu-grid-cols-3) { grid-template-columns: repeat(3, minmax(0, 1fr)); }
inside the matching @media (min-width: ...) block for the variants.
Decision to make
Either define every N each template can emit (smallest change, no markup change, keeps "N columns at every width" for the base class), or make the templates responsive so the setting is the maximum, for example wu-grid-cols-1 sm:wu-grid-cols-2 lg:wu-grid-cols-3 xl:wu-grid-cols-N. The second avoids four cramped columns on a phone but changes the layout of sites that already use 2 or 3 columns, so keep existing sites unchanged at N <= 3 unless there is a clear reason.
Verification
- With a customer who owns at least four sites, measure the grid's computed column count at 375, 768, 1024, 1280 and 1440px for
columns1 to 5 on a published page, and in the block-editor preview. - Confirm the limits and current-membership elements at their own maximum
columns. git diffof the stylesheet is additions only.pnpm run cleancssleaves no diff.
Tier
tier:standard. The affected files and reference pattern are known, but the responsive behaviour is a design choice.
aidevops.sh v3.39.189 plugin for OpenCode
- Lingua principale
- PHP
- Stelle
- 219
- Fork
- 88
- Merge medio
- 1g 7h
- PR unite (30g)
- 58
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di Ultimate-Multisite/ultimate-multisite
-
bug origin:interactive status:available
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
Ultimate-Multisite/ultimate-multisite#2131 ·
I maintainer di solito rispondono entro 1 giorno
-
bug hold-for-review no-auto-dispatch origin:interactive status:available
Difficoltà 3/5 1-2 giorni Idoneità per principianti 20/100
Ultimate-Multisite/ultimate-multisite#2140 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement hold-for-review no-auto-dispatch origin:interactive status:available
Difficoltà 5/5 Più di una settimana Idoneità per principianti 15/100
Ultimate-Multisite/ultimate-multisite#2137 ·
I maintainer di solito rispondono entro 1 giorno
-
fix: customer site lists stop at 100 sites (BerlinDB default number)Forse già presa @superdav42 l’ha presa oggi. Apertaauto-dispatch bug origin:interactive status:in-review tier:standard
Ultimate-Multisite/ultimate-multisite#2136 · 5 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
security(sso): apply mapped-domain token policy to admin-bar magic linksForse già presa @superdav42 l’ha presa 1 giorno fa. Apertaauto-dispatch origin:interactive status:in-review tier:standard
Ultimate-Multisite/ultimate-multisite#2125 · 5 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di Ultimate-Multisite/ultimate-multisite
Issue simili
-
35-feedback
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
bug good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
quantum-php/framework#692 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 70/100
ajeetraina/awesome-docker-sbx#559 ·
-
PHP 8.6 supportAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
-
Saisie des adressesAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
pantaflex44/Tiquettes#116 · 1 commento ·