Tearing.Dispersion - Exclude poles from the polish trust radius near a pole

Aperta
  • Qualcosa non va?
#609 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
1-2 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
julia
Ambito
machine-learning

Direzione di ricerca

Start by locating _polish_trust_radius and the validity gate; the issue does not name their files or a test harness. Read how raw contour intersections distinguish roots from poles, then check the existing pooling option described in #572. Reproduce the near-pole case with one triangulation and the gate enabled; done means the real root is accepted consistently and the harness run supports the change, with explicit sign-off.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

_polish_trust_radius caps each root's trust radius at 0.45 × the distance to its nearest neighbor among all raw contour intersections, and that list includes poles. Next to a pole the radius can shrink below the distance from the contour estimate to the true zero. The polish then cannot reach the zero, and the validity gate rejects a real root.

Which diagonals the AMR triangulation gives a cell moves both the start point and that distance. This is the likely cause of near-pole roots that pass the gate for some triangulations and not others (the problem the pooling option in #572 was written for).

The polish cannot be pulled into a pole, because it only accepts steps that decrease |f|, so the cap guards against the wrong thing near poles.

Proposal:

  1. Leave poles out of the nearest-neighbor distance (keep other roots).
  2. If the validity gate fails, retry once with R = k_cell·h.
  3. Test on a residual with a root about one cell from a pole, with the validity gate on.

This is deterministic, needs one triangulation, and costs one extra polish only when the gate fails. It changes which roots are accepted, so the new rule needs explicit sign-off and a harness run.

Lingua principale
Julia
Stelle
11
Fork
7
Merge medio
3g 22h
PR unite (30g)
70

Preparare l'ambiente

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di OpenFUSIONToolkit/GPEC

Tutte le issue di OpenFUSIONToolkit/GPEC

Issue simili

Altre issue su Julia

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.