Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Portability review: what is Bavarian, what is German, what is universal (tracking)

Aperta Adatta ai principianti
  • Qualcosa non va?
#405 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
62/100
Tipo di issue
Documentazione
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp, sqlite
Ambito
backend-api-design, documentation

Direzione di ricerca

Inizia con la revisione di main al commit ecb341b e dei risultati citati (#398–#404, #462); l’issue descrive l’ambito e le conclusioni della revisione della portabilità. Verifica le posizioni del codice sorgente citate, incluse src/ e IncidentDataDialogView.axaml:26, confrontandole con i risultati riportati. Il lavoro è concluso quando le ipotesi sulla portabilità e i due moduli di dominio non portabili sono documentati accuratamente; l’issue non specifica un file particolare da modificare.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

A review of main (ecb341b) asking three questions: how much of the implemented logic works for another Bavarian Feuerwehr, how much works elsewhere in Germany, and — setting the missing i18n aside — how much would work anywhere. This issue is the frame; the individual findings are filed separately below.

The short answer

Another Bavarian brigade: everything, unchanged. There is no catalogue of Bavarian practice to port. MasterDataStore.GetOrCreate seeds nothing and StammdatenCatalogue never rejects an unknown value, so roles, vehicle status, Trupp types, vehicles, call signs, Wachen, checklist contents and links are all user-supplied. IncidentNumber is eighteen lines whose only rule is non-blank — the B 1.2 JJMMTT lfd.Nr. scheme exists solely as a placeholder hint in IncidentDataDialogView.axaml:26 and a line in the README. There is no Dienstgrad model, no Landkreis, no Kreisbrandinspektion, no Alarmstufen, no AAO, no FMS status enum, no vehicle-type taxonomy and no Funkrufname grammar anywhere in src/.

Rest of Germany: everything, and one word is wrong. FwDV 7 and the AGW behind the CO bands are federal. The one Bavarian-but-not-German artefact is the label "ILS" (#400).

Anywhere else, ignoring language: the chassis travels intact — the append-only ETB with correction-by-annotation, role handover, tasks, attachments, links, checklists, the reminder timers, the file-per-incident format with its 21 migrations, offline multi-device sync, and the whole persistence layer. None of it keys off German law; the evidentiary model is general legal-record practice.

Two domain modules do not travel, and they are the only two: Atemschutz and CO-Messprotokoll.

Filed

Defects in Bavaria today, independent of any export ambition:

  • #398 — "CSA-Trupp" is a magic string; renaming the Trupp type silently drops the three-person crew rule
  • #399 — the Sicherheitstrupp is not modelled at all

Germany-wide:

  • #400 — "ILS" is hardcoded, including in the ETB entry written to the file
  • #401 — the address model cannot hold a house number, PLZ or Ort
  • #462 — the Einsatznummer follows the Bavarian ILS scheme (B 1.2 JJMMTT lfd.Nr.) only as a placeholder; other Leitstellen number differently, so the format should be configurable and pre-filled

Outside the German doctrine:

  • #402 — the retreat rule is a flat 50 bar; the Einstiegsdruck never enters it, and bar is a literal not a unit
  • #403 — the ppm bands are pegged to the German AGW and the floor labels to EG/OG/UG
  • #404 — the PDF is A4-only, with column widths tuned to hardcoded German headers

Added as comments to existing issues rather than filed fresh:

  • #350 / #299 — the domain composes German ETB prose that is persisted into the file, which makes it a data-model question and not only a display one
  • #397 — the master-data store has no version marker, so a renamed column or settings key would silently reset an install rather than fail

Not filed, deliberately

ForceUnit's shape — StrengthText is $"{Zf}/{Officer}/{Mannschaft}/{Total}" with exactly two leadership tiers baked into the aggregate — has no equivalent in services that count "engine with a crew of four". The right answer is almost certainly to render the four integers through a formatter rather than reshape the aggregate, since those integers are already a schema and sync-wire contract. That is a sub-point of #299 and needs no issue of its own until someone actually wants it.

Two incidental findings, neither worth an issue: the README's "Sirene" (README.md:68) does not exist — the retreat alarm is a clip repeated every 15 s, which #81 decided deliberately — and the spoken cues are four pre-recorded German WAVs rather than TTS, so localising audio means re-recording, not changing a locale string. The German words are not in the repo as text at all, only as XML comments on AlarmSound.

Why this is worth having written down

Nothing here argues Lagebuch should target other countries. The useful output is the opposite: it shows that the Bavarian assumptions people would expect to be baked in mostly are not, and that the ones that genuinely are — a flat Rückzugsdruck, AGW ppm bands, EG/OG/UG, a Trupp type identified by its German name — are in two modules and a handful of constants. Anyone reading Domain should know which constants are universal and which are local, and right now only CoSeverity says so in its own doc comment.

Lingua principale
C#
Stelle
1
Fork
3
Merge medio
4h 34m
PR unite (30g)
182

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di CodeForFire/lagebuch

Tutte le issue di CodeForFire/lagebuch

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.