Privacy skill liveness cross-check reads the same daemon snapshot it disambiguates

Open
  • Is something wrong?
#2,146 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
javascript, markdown
Domain
devtools, security

Research direction

Read hypaware-core/plugins-workspace/claude/skills/hypaware-privacy/SKILL.md and hypaware-core/plugins-workspace/claude/src/telemetry/source.js, then inspect the both-recorders tests mentioned in the acceptance condition. The issue calls for a design decision: use an independent observation, publish listener liveness separately, or accept the single-snapshot design and startup window. Done means the chosen decision is reflected in the skill text and the tests pin it.

Written by the indexing model from the issue text.

Description

Source: #2132 at 5cb427211f376caa686298f4ec21a788af946523
Location: hypaware-core/plugins-workspace/claude/skills/hypaware-privacy/SKILL.md:46, hypaware-core/plugins-workspace/claude/src/telemetry/source.js:297-338
Severity: minor

Evidence

The verb's recorder resolution and the capture-health listener_started_at both come from one liveness-gated read of run/status.json, and the shipped listener co-emits control_routes and listener_started_at in one unconditional details literal, so no second genuinely independent observation exists. Issue #1626's acceptance is met at head 5cb42721 (verified: the daemon.error clause makes the live stop branch reachable, capability_too_old and dead-daemon shapes proceed, running:true-with-error stops), so what remains is design-level: a cross-check source outside status.json, or a listener publishable without its route. The only behavioral residual is a reasoned-about, never-reproduced startup window (daemon alive, status file not yet written: running true, no error, null field reads as 'not running').

Why deferral is safe

Both named remainders are design changes; CLAUDE.md says land the small fix and defer the rest. The residual window is strictly narrower than the pre-PR behavior this PR fixed, transient (the next hyp status after the daemon flushes its snapshot corrects it), requires the user to run the privacy review in the seconds between daemon start and its first status write, and was never observed, so it does not meet the defect bar. The fail direction during that window matches the capability_too_old handling #1626 explicitly requires, and the two shapes are indistinguishable within the current single-snapshot design.

Acceptance condition

A design decision that either gives Step 1's cross-check an observation not derived from run/status.json (or makes the listener's liveness publishable independently of its route advertisement) with the skill text and both-recorders tests updated to pin it, or explicitly accepts the single-snapshot design and its startup window.

Review preference; backlog only. A human may explicitly delegate it with neutral:fix.

Dominant language
JavaScript
Stars
11
Forks
0
Avg merge
2h 55m
Merged PRs (30d)
294

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from hyparam/hypaware

All issues in hyparam/hypaware

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.