Privacy skill liveness cross-check reads the same daemon snapshot it disambiguates

Aperta
  • Qualcosa non va?
#2,146 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript, markdown
Ambito
devtools, security

Direzione di ricerca

Read hypaware-core/plugins-workspace/claude/skills/hypaware-privacy/SKILL.md and hypaware-core/plugins-workspace/claude/src/telemetry/source.js, then inspect the both-recorders tests mentioned in the acceptance condition. The issue calls for a design decision: use an independent observation, publish listener liveness separately, or accept the single-snapshot design and startup window. Done means the chosen decision is reflected in the skill text and the tests pin it.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Source: #2132 at 5cb427211f376caa686298f4ec21a788af946523
Location: hypaware-core/plugins-workspace/claude/skills/hypaware-privacy/SKILL.md:46, hypaware-core/plugins-workspace/claude/src/telemetry/source.js:297-338
Severity: minor

Evidence

The verb's recorder resolution and the capture-health listener_started_at both come from one liveness-gated read of run/status.json, and the shipped listener co-emits control_routes and listener_started_at in one unconditional details literal, so no second genuinely independent observation exists. Issue #1626's acceptance is met at head 5cb42721 (verified: the daemon.error clause makes the live stop branch reachable, capability_too_old and dead-daemon shapes proceed, running:true-with-error stops), so what remains is design-level: a cross-check source outside status.json, or a listener publishable without its route. The only behavioral residual is a reasoned-about, never-reproduced startup window (daemon alive, status file not yet written: running true, no error, null field reads as 'not running').

Why deferral is safe

Both named remainders are design changes; CLAUDE.md says land the small fix and defer the rest. The residual window is strictly narrower than the pre-PR behavior this PR fixed, transient (the next hyp status after the daemon flushes its snapshot corrects it), requires the user to run the privacy review in the seconds between daemon start and its first status write, and was never observed, so it does not meet the defect bar. The fail direction during that window matches the capability_too_old handling #1626 explicitly requires, and the two shapes are indistinguishable within the current single-snapshot design.

Acceptance condition

A design decision that either gives Step 1's cross-check an observation not derived from run/status.json (or makes the listener's liveness publishable independently of its route advertisement) with the skill text and both-recorders tests updated to pin it, or explicitly accepts the single-snapshot design and its startup window.

Review preference; backlog only. A human may explicitly delegate it with neutral:fix.

Lingua principale
JavaScript
Stelle
11
Fork
0
Merge medio
2h 55m
PR unite (30g)
294

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di hyparam/hypaware

Tutte le issue di hyparam/hypaware

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.