report_commands.js runtime output still says 'server' in four places; one names the destination

Open Beginner friendly
#2,203 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript
Domain
cli

Research direction

Read src/core/cli/report_commands.js around line 935 and find the report-render output expectation covering that sentence. Reword only the generated-Markdown sentence to use the settled destination vocabulary, leaving the three other server references unchanged; run the relevant report-render test and confirm its expected output is updated.

Written by the indexing model from the issue text.

Description

Source: #2195 at ffc56a5d71f5cc51dd32fb9da5b3fa85f8787665
Location: src/core/cli/report_commands.js:778,796,935,1165
Severity: low

Evidence

Verified at ffc56a5d: :778 and :796 say 'is the server up to date?' (naming the peer software), :1165 says 'ask a server admin' (naming a role), and :935 emits generated report Markdown saying 'They ran on the server over the whole org' (naming the destination). None are help surfaces, so the #2189 guard does not and should not reach them.

Why deferral is safe

Outside issue #2189's acceptance condition (help surfaces only). Three of the four uses are correct as-is because they name the peer software or a role, not the destination; only the :935 generated-Markdown sentence names the destination in the non-settled vocabulary. Smallest-change rule: left alone in this PR, recorded here.

Acceptance condition

A follow-up rewords only the :935 generated-Markdown sentence to the settled destination vocabulary (e.g. 'They ran on the remote over the whole org'), leaves :778, :796, and :1165 unchanged, and updates any report-render output expectation that covers that sentence.

Review preference; backlog only. A human may explicitly delegate it with neutral:fix.

Dominant language
JavaScript
Stars
11
Forks
0
Avg merge
2h 49m
Merged PRs (30d)
297

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from hyparam/hypaware

All issues in hyparam/hypaware

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.