Privacy skill liveness cross-check reads the same daemon snapshot it disambiguates

Abierto
  • ¿Algo no está bien?
#2,146 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
javascript, markdown
Área
devtools, security

Línea de trabajo

Read hypaware-core/plugins-workspace/claude/skills/hypaware-privacy/SKILL.md and hypaware-core/plugins-workspace/claude/src/telemetry/source.js, then inspect the both-recorders tests mentioned in the acceptance condition. The issue calls for a design decision: use an independent observation, publish listener liveness separately, or accept the single-snapshot design and startup window. Done means the chosen decision is reflected in the skill text and the tests pin it.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Source: #2132 at 5cb427211f376caa686298f4ec21a788af946523
Location: hypaware-core/plugins-workspace/claude/skills/hypaware-privacy/SKILL.md:46, hypaware-core/plugins-workspace/claude/src/telemetry/source.js:297-338
Severity: minor

Evidence

The verb's recorder resolution and the capture-health listener_started_at both come from one liveness-gated read of run/status.json, and the shipped listener co-emits control_routes and listener_started_at in one unconditional details literal, so no second genuinely independent observation exists. Issue #1626's acceptance is met at head 5cb42721 (verified: the daemon.error clause makes the live stop branch reachable, capability_too_old and dead-daemon shapes proceed, running:true-with-error stops), so what remains is design-level: a cross-check source outside status.json, or a listener publishable without its route. The only behavioral residual is a reasoned-about, never-reproduced startup window (daemon alive, status file not yet written: running true, no error, null field reads as 'not running').

Why deferral is safe

Both named remainders are design changes; CLAUDE.md says land the small fix and defer the rest. The residual window is strictly narrower than the pre-PR behavior this PR fixed, transient (the next hyp status after the daemon flushes its snapshot corrects it), requires the user to run the privacy review in the seconds between daemon start and its first status write, and was never observed, so it does not meet the defect bar. The fail direction during that window matches the capability_too_old handling #1626 explicitly requires, and the two shapes are indistinguishable within the current single-snapshot design.

Acceptance condition

A design decision that either gives Step 1's cross-check an observation not derived from run/status.json (or makes the listener's liveness publishable independently of its route advertisement) with the skill text and both-recorders tests updated to pin it, or explicitly accepts the single-snapshot design and its startup window.

Review preference; backlog only. A human may explicitly delegate it with neutral:fix.

Lenguaje dominante
JavaScript
Estrellas
11
Forks
0
Merge medio
2 h 49 min
PR fusionados (30 d)
302

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de hyparam/hypaware

Todos los issues de hyparam/hypaware

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.