Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

[workshop-sync] side-quest-11-05-event-triggers.md: PR reviewer references point to wrong step (15-conditional-logic.md instead of 14b-pr-review

Closed Beginner friendly
  • Is something wrong?
#4,366 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Tech stack
github-actions
Domain
documentation

Research direction

Start in workshop/side-quest-11-05-event-triggers.md and find every link or label that points to 15-conditional-logic.md as the PR Code Reviewer, plus the 'Step 11c' label and the Step 7 vs Step 15 comparison table. Check workshop/14b-pr-reviewer-workflow.md for the real title and its pull_request trigger and submit-pull-request-review safe output, and workshop/README.md for the curriculum table. Done when every reference points to 14b with the correct title, and the table row matches 14b's trigger and safe output.

Written by the indexing model from the issue text.

Description

documentation

Workshop file reviewed

workshop/side-quest-11-05-event-triggers.md

Problem

This side quest repeatedly calls 15-conditional-logic.md the "PR Code Reviewer" step and labels it "Step 11c" / "Step 15":

...before you finish Build — PR Code Reviewer, then return to the main adventure.

This is a good fit when you want feedback tied to the current PR, like the PR Code Reviewer in Step 11c.

The Daily Repo Status workflow in Step 7 and the PR Code Reviewer in Step 15 use the same workflow format...

Return to the main adventure: Build — PR Code Reviewer.

But workshop/15-conditional-logic.md is actually titled "Make Your Workflow Smarter with Conditional Logic" — it adds an if: guard to the existing schedule-triggered daily-status workflow from Step 7. It has no pull_request trigger, no PR-review content, and no add-comment/create-issue safe-outputs block at all.

The actual PR reviewer workshop content lives at workshop/14b-pr-reviewer-workflow.md ("Build a PR Reviewer with an Agent and Skill"), confirmed by the curriculum table in workshop/README.md:

| 14b | [Build Your First Event-Driven Workflow: PR Auto-Reviewer](14b-pr-reviewer-workflow.md) |
| 15 | [Make Your Workflow Smarter with Conditional Logic](15-conditional-logic.md) |

There is also no "Step 11c" anywhere in the curriculum — the nearest step is 14b.

Additionally, the "Concrete example: Step 7 vs Step 15" table claims Step 15 uses add-comment as its safe output, but Step 15 doesn't define a trigger or safe-outputs change at all (it only adds an if: condition to Step 7's workflow) — this table row should reference Step 14b's actual trigger (pull_request: types: [ready_for_review]) and safe output (submit-pull-request-review, per workshop/14b-pr-reviewer-workflow.md), not Step 15.

Current correct behavior

  • The PR Code Reviewer content is Step 14b (14b-pr-reviewer-workflow.md), not Step 15 or "Step 11c".
  • Step 14b's workflow uses on: pull_request: types: [ready_for_review] and safe-outputs: submit-pull-request-review (not add-comment).

Suggested fix

  1. Replace all links/labels pointing to 15-conditional-logic.md as "PR Code Reviewer" with links to 14b-pr-reviewer-workflow.md, using its real title "Build a PR Reviewer with an Agent and Skill" (or "PR Auto-Reviewer" per the README).
  2. Change "Step 11c" to "Step 14b".
  3. Update the "Concrete example" comparison table to reference Step 14b's actual trigger/safe-output pair instead of Step 15's.

Generated by 🔍 Workshop Sync Check · copilot · auto · 183 AIC · ⌖ 6.38 AIC · ⊞ 9.2K · ◷

  • expires on Oct 10, 2026, 5:02 AM UTC
Dominant language
JavaScript
Stars
52
Forks
26
Avg merge
12h 25m
Merged PRs (30d)
18

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

  • No Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from githubnext/gh-aw-workshop

All issues in githubnext/gh-aw-workshop

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.