Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

[workshop-sync] side-quest-11-05-event-triggers.md: PR reviewer references point to wrong step (15-conditional-logic.md instead of 14b-pr-review

已关闭 适合新手
  • 哪里不对？
#4,366 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
78/100
Issue 类型
文档
描述清晰度
描述清楚
活跃度
活跃
技术栈
github-actions
领域
documentation

调研方向

从 workshop/side-quest-11-05-event-triggers.md 开始，找出所有将 PR Code Reviewer 指向 15-conditional-logic.md 的链接或标签，以及 'Step 11c' 标签和 Step 7 vs Step 15 对比表。检查 workshop/14b-pr-reviewer-workflow.md 中的实际标题、pull_request 触发器和 submit-pull-request-review 安全输出，并检查 workshop/README.md 中的课程表。当每个引用都指向 14b 且标题正确，表格行与 14b 的触发器和安全输出一致时，即完成。

由索引模型根据 Issue 内容生成。

描述

documentation

Workshop file reviewed

workshop/side-quest-11-05-event-triggers.md

Problem

This side quest repeatedly calls 15-conditional-logic.md the "PR Code Reviewer" step and labels it "Step 11c" / "Step 15":

...before you finish Build — PR Code Reviewer, then return to the main adventure.

This is a good fit when you want feedback tied to the current PR, like the PR Code Reviewer in Step 11c.

The Daily Repo Status workflow in Step 7 and the PR Code Reviewer in Step 15 use the same workflow format...

Return to the main adventure: Build — PR Code Reviewer.

But workshop/15-conditional-logic.md is actually titled "Make Your Workflow Smarter with Conditional Logic" — it adds an if: guard to the existing schedule-triggered daily-status workflow from Step 7. It has no pull_request trigger, no PR-review content, and no add-comment/create-issue safe-outputs block at all.

The actual PR reviewer workshop content lives at workshop/14b-pr-reviewer-workflow.md ("Build a PR Reviewer with an Agent and Skill"), confirmed by the curriculum table in workshop/README.md:

| 14b | [Build Your First Event-Driven Workflow: PR Auto-Reviewer](14b-pr-reviewer-workflow.md) |
| 15 | [Make Your Workflow Smarter with Conditional Logic](15-conditional-logic.md) |

There is also no "Step 11c" anywhere in the curriculum — the nearest step is 14b.

Additionally, the "Concrete example: Step 7 vs Step 15" table claims Step 15 uses add-comment as its safe output, but Step 15 doesn't define a trigger or safe-outputs change at all (it only adds an if: condition to Step 7's workflow) — this table row should reference Step 14b's actual trigger (pull_request: types: [ready_for_review]) and safe output (submit-pull-request-review, per workshop/14b-pr-reviewer-workflow.md), not Step 15.

Current correct behavior

  • The PR Code Reviewer content is Step 14b (14b-pr-reviewer-workflow.md), not Step 15 or "Step 11c".
  • Step 14b's workflow uses on: pull_request: types: [ready_for_review] and safe-outputs: submit-pull-request-review (not add-comment).

Suggested fix

  1. Replace all links/labels pointing to 15-conditional-logic.md as "PR Code Reviewer" with links to 14b-pr-reviewer-workflow.md, using its real title "Build a PR Reviewer with an Agent and Skill" (or "PR Auto-Reviewer" per the README).
  2. Change "Step 11c" to "Step 14b".
  3. Update the "Concrete example" comparison table to reference Step 14b's actual trigger/safe-output pair instead of Step 15's.

Generated by 🔍 Workshop Sync Check · copilot · auto · 183 AIC · ⌖ 6.38 AIC · ⊞ 9.2K · ◷

  • expires on Oct 10, 2026, 5:02 AM UTC
主要语言
JavaScript
星标
55
派生
36
平均合并
2 天 8 小时
30 天内合并 PR
17

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

githubnext/gh-aw-workshop 的其他 Issue

查看 githubnext/gh-aw-workshop 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。