Ralph mode: approval gates before push, PR and merge actions

Ouverte
#2,465 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
45/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Active
Stack technique
github, typescript

Piste de recherche

Read .squad-templates/squad.agent.md item 9, packages/squad-sdk/src/client/adapters/coordinator.ts, ralph-charter.md, and ralph-reference.md to map the current Ralph instructions and their mirrors. Then inspect the plugin build script and tests that check generated projections. Done means every host's Ralph text names the approval gate, a test checks each projection, the relevant docs describe the gate, and the plugin build completes.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Problem

Ralph mode (the coordinator's backlog work-monitor loop) scans GitHub, then creates branches, pushes, opens PRs and merges approved PRs. It's told not to stop and ask permission between items. Code scanning flagged this as an excessive-agency risk on the Claude Code plugin's copy of the text in #2463 (thread).

The behaviour isn't new in #2463. The same text is in:

  • the coordinator prompt: .squad-templates/squad.agent.md, item 9, and its mirrors
  • the Claude coordinator projection: packages/squad-sdk/src/client/adapters/coordinator.ts (since #2251 and #2450)
  • ralph-charter.md and ralph-reference.md

The plugin copies it as is. Changing Ralph's semantics is a product decision for all hosts, so it's tracked here rather than in the plugin PR.

Proposal

  • Keep reading autonomous: scanning, triage, routing, reporting and rescanning.
  • Put a deterministic gate in front of state-changing GitHub actions: push, PR create or edit, merge, close or reopen, label changes and workflow reruns. Options:
    • Per item: the coordinator shows the planned write and waits for approval.
    • Scoped pre-approval: the user grants it when starting Ralph (for example "Ralph, go — may open PRs, never merge"), and the coordinator records and honours it.
    • Host permissions: on Claude Code, rely on the permission system (no allowed-tools grants for git push or gh pr merge), and say so in the prompt.
  • Keep the existing reviewer, circuit-breaker and auth checks.
  • Apply the change in the canonical template, the Claude projection and the plugin. Then regenerate the mirrors and run node scripts/build-claude-plugin.mjs.

Done when

  • The Ralph text on every host names the approval gate.
  • A test asserts that the gate's wording appears in each projection.
  • The docs (concepts/github-workflow.md, the watch-monitor blog post where relevant) describe the gate.

Related: #2438, #2443, #2463.

Langage dominant
TypeScript
Étoiles
3.4k
Forks
516
Merge moyen
1 j 15 h
PR mergées (30 j)
116

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de github/squad

Toutes les issues de github/squad

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.