Ralph mode: approval gates before push, PR and merge actions

Aberta
#2,465 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
45/100
Tipo de issue
Funcionalidade
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
github, typescript

Direção de pesquisa

Read .squad-templates/squad.agent.md item 9, packages/squad-sdk/src/client/adapters/coordinator.ts, ralph-charter.md, and ralph-reference.md to map the current Ralph instructions and their mirrors. Then inspect the plugin build script and tests that check generated projections. Done means every host's Ralph text names the approval gate, a test checks each projection, the relevant docs describe the gate, and the plugin build completes.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Problem

Ralph mode (the coordinator's backlog work-monitor loop) scans GitHub, then creates branches, pushes, opens PRs and merges approved PRs. It's told not to stop and ask permission between items. Code scanning flagged this as an excessive-agency risk on the Claude Code plugin's copy of the text in #2463 (thread).

The behaviour isn't new in #2463. The same text is in:

  • the coordinator prompt: .squad-templates/squad.agent.md, item 9, and its mirrors
  • the Claude coordinator projection: packages/squad-sdk/src/client/adapters/coordinator.ts (since #2251 and #2450)
  • ralph-charter.md and ralph-reference.md

The plugin copies it as is. Changing Ralph's semantics is a product decision for all hosts, so it's tracked here rather than in the plugin PR.

Proposal

  • Keep reading autonomous: scanning, triage, routing, reporting and rescanning.
  • Put a deterministic gate in front of state-changing GitHub actions: push, PR create or edit, merge, close or reopen, label changes and workflow reruns. Options:
    • Per item: the coordinator shows the planned write and waits for approval.
    • Scoped pre-approval: the user grants it when starting Ralph (for example "Ralph, go — may open PRs, never merge"), and the coordinator records and honours it.
    • Host permissions: on Claude Code, rely on the permission system (no allowed-tools grants for git push or gh pr merge), and say so in the prompt.
  • Keep the existing reviewer, circuit-breaker and auth checks.
  • Apply the change in the canonical template, the Claude projection and the plugin. Then regenerate the mirrors and run node scripts/build-claude-plugin.mjs.

Done when

  • The Ralph text on every host names the approval gate.
  • A test asserts that the gate's wording appears in each projection.
  • The docs (concepts/github-workflow.md, the watch-monitor blog post where relevant) describe the gate.

Related: #2438, #2443, #2463.

Linguagem predominante
TypeScript
Estrelas
3.4k
Forks
516
Merge médio
1d 15h
PRs com merge (30d)
116

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de github/squad

Todas as issues de github/squad

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.