Ralph mode: approval gates before push, PR and merge actions

Aperta
#2,465 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
github, typescript

Direzione di ricerca

Read .squad-templates/squad.agent.md item 9, packages/squad-sdk/src/client/adapters/coordinator.ts, ralph-charter.md, and ralph-reference.md to map the current Ralph instructions and their mirrors. Then inspect the plugin build script and tests that check generated projections. Done means every host's Ralph text names the approval gate, a test checks each projection, the relevant docs describe the gate, and the plugin build completes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem

Ralph mode (the coordinator's backlog work-monitor loop) scans GitHub, then creates branches, pushes, opens PRs and merges approved PRs. It's told not to stop and ask permission between items. Code scanning flagged this as an excessive-agency risk on the Claude Code plugin's copy of the text in #2463 (thread).

The behaviour isn't new in #2463. The same text is in:

  • the coordinator prompt: .squad-templates/squad.agent.md, item 9, and its mirrors
  • the Claude coordinator projection: packages/squad-sdk/src/client/adapters/coordinator.ts (since #2251 and #2450)
  • ralph-charter.md and ralph-reference.md

The plugin copies it as is. Changing Ralph's semantics is a product decision for all hosts, so it's tracked here rather than in the plugin PR.

Proposal

  • Keep reading autonomous: scanning, triage, routing, reporting and rescanning.
  • Put a deterministic gate in front of state-changing GitHub actions: push, PR create or edit, merge, close or reopen, label changes and workflow reruns. Options:
    • Per item: the coordinator shows the planned write and waits for approval.
    • Scoped pre-approval: the user grants it when starting Ralph (for example "Ralph, go — may open PRs, never merge"), and the coordinator records and honours it.
    • Host permissions: on Claude Code, rely on the permission system (no allowed-tools grants for git push or gh pr merge), and say so in the prompt.
  • Keep the existing reviewer, circuit-breaker and auth checks.
  • Apply the change in the canonical template, the Claude projection and the plugin. Then regenerate the mirrors and run node scripts/build-claude-plugin.mjs.

Done when

  • The Ralph text on every host names the approval gate.
  • A test asserts that the gate's wording appears in each projection.
  • The docs (concepts/github-workflow.md, the watch-monitor blog post where relevant) describe the gate.

Related: #2438, #2443, #2463.

Lingua principale
TypeScript
Stelle
3.4k
Fork
516
Merge medio
1g 15h
PR unite (30g)
116

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di github/squad

Tutte le issue di github/squad

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.