squad-sdk: spawnAgent ignores the persistent reasoning-effort and context-tier settings that its own commit documents

Ouverte Adaptée aux débutants
#2,521 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
2/5
Temps estimé
1-3 heures
Accessibilité débutants
82/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript

Piste de recherche

Lis packages/squad-sdk/src/agents/lifecycle.ts et les résolveurs des paramètres persistants dans packages/squad-sdk/src/config/models.ts. Examine ensuite les tests de spawn dans test/lifecycle.test.ts, où la configuration de createSession est déjà capturée. Ajoute une couverture pour defaultReasoningEffort et defaultContextTier ; l’issue est résolue lorsque les deux valeurs parviennent à la session et que la priorité documentée est vérifiée.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Summary

The two commits that threaded reasoning effort and context tier through agent spawning introduced
three things together:

  • the readers and the layered resolver in packages/squad-sdk/src/config/models.ts
    (readReasoningEffort, readAgentReasoningEffortOverrides, and the tier equivalents, 333 lines);
  • the template documentation that promises the layer -- .squad-templates/squad.agent.md, "1.
    Persistent Config: .squad/config.json ? agentReasoningEffortOverrides.{agentName}, then
    defaultReasoningEffort";
  • and the inline resolution in AgentLifecycleManager.spawnAgent that skips it:
const rawEffort = reasoningEffortOverride
  || agentConfig.resolvedReasoningEffort
  || undefined;

Environment

  • github/squad (the report was written against the bradygaster/squad fork, which carries the same
    commits; dev has the identical lines at packages/squad-sdk/src/agents/lifecycle.ts:328)
  • effort: 264b87612a -- feat(sdk): thread reasoningEffort through agent spawning pipeline (#1148),
    Co-authored-by: Copilot <[email protected]>
  • tier: f682ecb7ad -- feat(sdk,cli): thread contextTier through agent spawning pipeline (#1448),
    Co-authored-by: Copilot App <[email protected]>

Steps to reproduce

test/lifecycle.test.ts already wraps createSession and keeps every config in
sessionConfigs, and it already asserts on sessionConfigs[0].model for the persistent-config cases
(agentModelOverrides, defaultModel, 'auto'). The effort and the tier are the only two settings
that file never asserts on.

Take one of those cases, add defaultReasoningEffort and defaultContextTier to the
.squad/config.json it writes, and assert the same way:

expect(sessionConfigs[0]?.reasoningEffort).toBe('high');
expect(sessionConfigs[0]?.contextTier).toBe('long_context');

The capture itself needs no change -- it is the file's own.

Actual behavior

Running one of those persistent-config cases with defaultReasoningEffort: "high" and
defaultContextTier: "long_context" added to the config file, and no effort or tier anywhere else,
the object handed to createSession is:

{ "model": "charter-model", "systemMessage": { "content": "..." } }

reasoningEffort and contextTier are both absent (undefined), while model is the one the
charter names -- so the spawn ran, the config file was read, and only these two settings never reached
the session. Adding the assertion to that case fails:

AssertionError: expected undefined to be 'high' // Object.is equality
- Expected: "high"
+ Received:  undefined

Changing one input at a time, the same capture shows which layers do arrive:

variant .squad/config.json charter spawn option reasoningEffort in the session
A defaultReasoningEffort: high none none undefined
B none **Reasoning Effort:** medium none "medium"
C defaultReasoningEffort: high none reasoningEffortOverride: low "low"
D defaultReasoningEffort: high **Reasoning Effort:** medium none "medium"

A is the documented layer 1 and the only one that produces nothing. D shows the persistent value
losing to a charter value the documentation ranks below it. The tier behaves the same way: a charter
naming **Context Tier:** long_context reaches the session, defaultContextTier does not.

Expected behavior

{ "model": "claude-sonnet-5.5", "reasoningEffort": "high", "contextTier": "long_context" }

Suggested fix

The resolver the same commits added already implements the documented order; call it instead of
resolving inline:

const rawEffort = resolveReasoningEffort({
  agentName, squadDir,
  spawnOverride: reasoningEffortOverride,
  charterPreference: agentConfig.resolvedReasoningEffort,
});

Failing that, add the two persistent lookups in front of the charter value.

Langage dominant
TypeScript
Étoiles
3.4k
Forks
516
Merge moyen
1 j 15 h
PR mergées (30 j)
116

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de github/squad

Toutes les issues de github/squad

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.