Potential unsafe reuse of `renderFinishedSemaphore`

Ouverte
#533 0 commentaires 0 réactions 1 personne assignée Voir sur GitHub

Les mainteneurs répondent en général sous 16 jours

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
61/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
cpp
Domaine
backend, testing-qa

Piste de recherche

Read 15_hello_triangle.cpp alongside 16_frames_in_flight.cpp and the linked Vulkan Guide on swapchain semaphore reuse. Check whether the chapter 15 submission and presentation sequence permits reusing the semaphore before presentation has finished waiting on it. Done when the specification or a reproducer establishes whether reuse is safe and, if not, the example’s synchronization is corrected.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

While reading the Rendering and Presentation chapter, I noticed a potential synchronization issue in 15_hello_triangle.cpp.

The example creates a single renderFinishedSemaphore, which is reused for every frame. It is signaled by queue.submit() and waited on by queue.presentKHR().

My concern is that the semaphore might be reused before the previous presentation operation has finished waiting on it.

For example, consider the following sequence:

Frame 0:

  1. The application submits rendering commands for swapchain Image 0, with drawFence and renderFinishedSemaphore.
  2. Once the rendering submission completes, both drawFence and renderFinishedSemaphore are signaled.
  3. The presentation operation waits on renderFinishedSemaphore. However, this wait may not have completed yet.

Frame 1: (assuming Frame 0's presentation wait on renderFinishedSemaphore has not yet completed):

  1. The CPU waits on drawFence. Since Frame 0's rendering has completed, the fence wait can return.
  2. The application acquires another swapchain image, say Image 1, and submits rendering commands for Frame 1.
  3. This submission attempts to signal the same renderFinishedSemaphore again.

The potential issue is that Frame 0's presentation operation may still be waiting on renderFinishedSemaphore when Frame 1 attempts to signal it again.

Since this is a binary semaphore, it must return to the unsignaled state before it can be signaled again. Waiting for drawFence only guarantees that Frame 0's rendering submission has completed, not that its presentation wait has completed.

The Vulkan Guide on Swapchain Semaphore Reuse discusses a similar problem, where a rendering fence does not guarantee that a semaphore used by presentation is safe to reuse.

I also noticed that the next example, 16_frames_in_flight.cpp uses renderFinishedSemaphores[imageIndex], so it doesn't appear to have the same issue.

I haven't reproduced a validation error myself, but I was wondering whether this semaphore reuse in chapter 15 is guaranteed to be safe by the Vulkan specification.

Thanks!

Langage dominant
C++
Étoiles
444
Forks
145
Merge moyen
12 j 10 h
PR mergées (30 j)
12

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de KhronosGroup/Vulkan-Tutorial

Toutes les issues de KhronosGroup/Vulkan-Tutorial

Issues similaires

Plus d'issues C++

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.