Potential unsafe reuse of `renderFinishedSemaphore`
Mantenedores costumam responder em até 16 dias
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Facilidade para iniciantes
- 61/100
- Tipo de issue
- Bug
- Clareza
- Razoavelmente clara
- Status de atividade
- Ativa
- Stack de tecnologia
- cpp
- Domínio
- backend, testing-qa
Direção de pesquisa
Read 15_hello_triangle.cpp alongside 16_frames_in_flight.cpp and the linked Vulkan Guide on swapchain semaphore reuse. Check whether the chapter 15 submission and presentation sequence permits reusing the semaphore before presentation has finished waiting on it. Done when the specification or a reproducer establishes whether reuse is safe and, if not, the example’s synchronization is corrected.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
While reading the Rendering and Presentation chapter, I noticed a potential synchronization issue in 15_hello_triangle.cpp.
The example creates a single renderFinishedSemaphore, which is reused for every frame. It is signaled by queue.submit() and waited on by queue.presentKHR().
My concern is that the semaphore might be reused before the previous presentation operation has finished waiting on it.
For example, consider the following sequence:
Frame 0:
- The application submits rendering commands for swapchain Image 0, with
drawFenceandrenderFinishedSemaphore. - Once the rendering submission completes, both
drawFenceandrenderFinishedSemaphoreare signaled. - The presentation operation waits on
renderFinishedSemaphore. However, this wait may not have completed yet.
Frame 1: (assuming Frame 0's presentation wait on renderFinishedSemaphore has not yet completed):
- The CPU waits on
drawFence. Since Frame 0's rendering has completed, the fence wait can return. - The application acquires another swapchain image, say Image 1, and submits rendering commands for Frame 1.
- This submission attempts to signal the same
renderFinishedSemaphoreagain.
The potential issue is that Frame 0's presentation operation may still be waiting on renderFinishedSemaphore when Frame 1 attempts to signal it again.
Since this is a binary semaphore, it must return to the unsignaled state before it can be signaled again. Waiting for drawFence only guarantees that Frame 0's rendering submission has completed, not that its presentation wait has completed.
The Vulkan Guide on Swapchain Semaphore Reuse discusses a similar problem, where a rendering fence does not guarantee that a semaphore used by presentation is safe to reuse.
I also noticed that the next example, 16_frames_in_flight.cpp uses renderFinishedSemaphores[imageIndex], so it doesn't appear to have the same issue.
I haven't reproduced a validation error myself, but I was wondering whether this semaphore reuse in chapter 15 is guaranteed to be safe by the Vulkan specification.
Thanks!
- Linguagem predominante
- C++
- Estrelas
- 444
- Forks
- 145
- Merge médio
- 12d 10h
- PRs com merge (30d)
- 12
Preparar o ambiente
- Sem Dockerfile nem arquivo Docker Compose
- Sem modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de KhronosGroup/Vulkan-Tutorial
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
KhronosGroup/Vulkan-Tutorial#552 ·
Mantenedores costumam responder em até 16 dias
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
KhronosGroup/Vulkan-Tutorial#551 ·
Mantenedores costumam responder em até 16 dias
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 85/100
KhronosGroup/Vulkan-Tutorial#545 ·
Mantenedores costumam responder em até 16 dias
-
Dificuldade 1/5 1-3 horas Facilidade para iniciantes 76/100
KhronosGroup/Vulkan-Tutorial#544 ·
Mantenedores costumam responder em até 16 dias
-
Clarify front-face culling when using a negative viewport heightTalvez já em andamento @1sgtpepper assumiu há 19 dias. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
KhronosGroup/Vulkan-Tutorial#534 ·
Mantenedores costumam responder em até 16 dias
Todas as issues de KhronosGroup/Vulkan-Tutorial
Issues semelhantes
-
Reference check: findingsAbertaaudit-reference-check
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
schrodinger/pymol-open-source#532 ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 82/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
xlnt-community/xlnt#174 ·