Potential unsafe reuse of `renderFinishedSemaphore`

Aberta
#533 0 comentários 0 reações 1 responsável Ver no GitHub

Mantenedores costumam responder em até 16 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
61/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
cpp
Domínio
backend, testing-qa

Direção de pesquisa

Read 15_hello_triangle.cpp alongside 16_frames_in_flight.cpp and the linked Vulkan Guide on swapchain semaphore reuse. Check whether the chapter 15 submission and presentation sequence permits reusing the semaphore before presentation has finished waiting on it. Done when the specification or a reproducer establishes whether reuse is safe and, if not, the example’s synchronization is corrected.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

While reading the Rendering and Presentation chapter, I noticed a potential synchronization issue in 15_hello_triangle.cpp.

The example creates a single renderFinishedSemaphore, which is reused for every frame. It is signaled by queue.submit() and waited on by queue.presentKHR().

My concern is that the semaphore might be reused before the previous presentation operation has finished waiting on it.

For example, consider the following sequence:

Frame 0:

  1. The application submits rendering commands for swapchain Image 0, with drawFence and renderFinishedSemaphore.
  2. Once the rendering submission completes, both drawFence and renderFinishedSemaphore are signaled.
  3. The presentation operation waits on renderFinishedSemaphore. However, this wait may not have completed yet.

Frame 1: (assuming Frame 0's presentation wait on renderFinishedSemaphore has not yet completed):

  1. The CPU waits on drawFence. Since Frame 0's rendering has completed, the fence wait can return.
  2. The application acquires another swapchain image, say Image 1, and submits rendering commands for Frame 1.
  3. This submission attempts to signal the same renderFinishedSemaphore again.

The potential issue is that Frame 0's presentation operation may still be waiting on renderFinishedSemaphore when Frame 1 attempts to signal it again.

Since this is a binary semaphore, it must return to the unsignaled state before it can be signaled again. Waiting for drawFence only guarantees that Frame 0's rendering submission has completed, not that its presentation wait has completed.

The Vulkan Guide on Swapchain Semaphore Reuse discusses a similar problem, where a rendering fence does not guarantee that a semaphore used by presentation is safe to reuse.

I also noticed that the next example, 16_frames_in_flight.cpp uses renderFinishedSemaphores[imageIndex], so it doesn't appear to have the same issue.

I haven't reproduced a validation error myself, but I was wondering whether this semaphore reuse in chapter 15 is guaranteed to be safe by the Vulkan specification.

Thanks!

Linguagem predominante
C++
Estrelas
444
Forks
145
Merge médio
12d 10h
PRs com merge (30d)
12

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de KhronosGroup/Vulkan-Tutorial

Todas as issues de KhronosGroup/Vulkan-Tutorial

Issues semelhantes

Mais issues de C++

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.