Potential unsafe reuse of `renderFinishedSemaphore`

Aperta
#533 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 16 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
61/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
cpp

Direzione di ricerca

Read 15_hello_triangle.cpp alongside 16_frames_in_flight.cpp and the linked Vulkan Guide on swapchain semaphore reuse. Check whether the chapter 15 submission and presentation sequence permits reusing the semaphore before presentation has finished waiting on it. Done when the specification or a reproducer establishes whether reuse is safe and, if not, the example’s synchronization is corrected.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

While reading the Rendering and Presentation chapter, I noticed a potential synchronization issue in 15_hello_triangle.cpp.

The example creates a single renderFinishedSemaphore, which is reused for every frame. It is signaled by queue.submit() and waited on by queue.presentKHR().

My concern is that the semaphore might be reused before the previous presentation operation has finished waiting on it.

For example, consider the following sequence:

Frame 0:

  1. The application submits rendering commands for swapchain Image 0, with drawFence and renderFinishedSemaphore.
  2. Once the rendering submission completes, both drawFence and renderFinishedSemaphore are signaled.
  3. The presentation operation waits on renderFinishedSemaphore. However, this wait may not have completed yet.

Frame 1: (assuming Frame 0's presentation wait on renderFinishedSemaphore has not yet completed):

  1. The CPU waits on drawFence. Since Frame 0's rendering has completed, the fence wait can return.
  2. The application acquires another swapchain image, say Image 1, and submits rendering commands for Frame 1.
  3. This submission attempts to signal the same renderFinishedSemaphore again.

The potential issue is that Frame 0's presentation operation may still be waiting on renderFinishedSemaphore when Frame 1 attempts to signal it again.

Since this is a binary semaphore, it must return to the unsignaled state before it can be signaled again. Waiting for drawFence only guarantees that Frame 0's rendering submission has completed, not that its presentation wait has completed.

The Vulkan Guide on Swapchain Semaphore Reuse discusses a similar problem, where a rendering fence does not guarantee that a semaphore used by presentation is safe to reuse.

I also noticed that the next example, 16_frames_in_flight.cpp uses renderFinishedSemaphores[imageIndex], so it doesn't appear to have the same issue.

I haven't reproduced a validation error myself, but I was wondering whether this semaphore reuse in chapter 15 is guaranteed to be safe by the Vulkan specification.

Thanks!

Lingua principale
C++
Stelle
444
Fork
145
Merge medio
12g 10h
PR unite (30g)
12

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di KhronosGroup/Vulkan-Tutorial

Tutte le issue di KhronosGroup/Vulkan-Tutorial

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.