Using multiple Slots within a Component

Open
  • Is something wrong?
#353 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
react, typescript
Domain
developer-experience

Research direction

Start with the Code Connect documentation and the implementation of figma.children and figma.instance to determine whether multiple named slots can be mapped independently. The issue provides no source files or tests to begin from, so first identify the relevant API entry points and existing slot tests. Done means documenting or supporting a clear way to connect both content and action slots in one component.

Written by the indexing model from the issue text.

Description

feature request

I'll start by saying that I'm not developer and my knowledge of React and Code Connect has been self taught. I apologize if this can already be done and I'm just missing something...

We have a component where we have multiple Props that we are using Slots for:

<ComponentName
   content={}
   actions={}
/>

Here's an example of our figma.tsx

import { ComponentName } from '@something';
import  figma from `@figma/code-connect`;

const FigmaLink = "..."

const ComponentNameProps = {
   content: figma.boolean("Content", {
      false: undefined,
      true: figma.children('ContentSlot')
   }),
   action: figma.boolean("Action", {
      false: undefined,
      true: figma.children('ActionSlot')
   })
};

figma.connect(ComponentName, FigmaLink , {
   props: {
      ...ComponentNameProps,
   },
   example: ({ content, action }) => {
      return <ComponentName content={content} action={action} />;
   }
});

Note: we separate our Links and Props whenever we use different variant use case examples.

In previous cases where we used Slots, it was set as children with a catchall (figma.children('*')) and this works great. I'm struggling to find a way of implementing the Code Connect for these components without having to create subComponents using the catch all method:

I haven't tested this but this is what I would do in that case:

_ComponentNameContent and _ComponentNameAction:

import { Fragment } from '@something';
import  figma from `@figma/code-connect`;

figma.connect(
   Fragment,
   '...', 
   {
       props: {
           children: figma.children('*'),
       }.
       example: ({ children }) => (
           <Fragment>{children}</Fragment>
       )
   }
)

Then the Code Connect would be:

import { ComponentName } from '@something';
import  figma from `@figma/code-connect`;

const FigmaLink = "..."

const ComponentNameProps = {
   content: figma.boolean("Content", {
      false: undefined,
      true: figma.instance('_ComponentNameContent')
   }),
   action: figma.boolean("Action", {
      false: undefined,
      true: figma.children('_ComponentNameAction')
   })
};

figma.connect(ComponentName, FigmaLink , {
   props: {
      ...ComponentNameProps,
   },
   example: ({ content, action }) => {
      return <ComponentName content={content} action={action} />;
   }
});

Sorry if there's some errors, I had to type this all up from my personal computer since I don't have access to GH on my work computer. Does anyone have any thoughts/solutions?

Dominant language
TypeScript
Stars
1.6k
Forks
126
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from figma/code-connect

All issues in figma/code-connect

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.