Using multiple Slots within a Component

未关闭
#353 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
48/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
停滞
技术栈
react, typescript

调研方向

Start with the Code Connect documentation and the implementation of figma.children and figma.instance to determine whether multiple named slots can be mapped independently. The issue provides no source files or tests to begin from, so first identify the relevant API entry points and existing slot tests. Done means documenting or supporting a clear way to connect both content and action slots in one component.

由索引模型根据 Issue 内容生成。

描述

feature request

I'll start by saying that I'm not developer and my knowledge of React and Code Connect has been self taught. I apologize if this can already be done and I'm just missing something...

We have a component where we have multiple Props that we are using Slots for:

<ComponentName
   content={}
   actions={}
/>

Here's an example of our figma.tsx

import { ComponentName } from '@something';
import  figma from `@figma/code-connect`;

const FigmaLink = "..."

const ComponentNameProps = {
   content: figma.boolean("Content", {
      false: undefined,
      true: figma.children('ContentSlot')
   }),
   action: figma.boolean("Action", {
      false: undefined,
      true: figma.children('ActionSlot')
   })
};

figma.connect(ComponentName, FigmaLink , {
   props: {
      ...ComponentNameProps,
   },
   example: ({ content, action }) => {
      return <ComponentName content={content} action={action} />;
   }
});

Note: we separate our Links and Props whenever we use different variant use case examples.

In previous cases where we used Slots, it was set as children with a catchall (figma.children('*')) and this works great. I'm struggling to find a way of implementing the Code Connect for these components without having to create subComponents using the catch all method:

I haven't tested this but this is what I would do in that case:

_ComponentNameContent and _ComponentNameAction:

import { Fragment } from '@something';
import  figma from `@figma/code-connect`;

figma.connect(
   Fragment,
   '...', 
   {
       props: {
           children: figma.children('*'),
       }.
       example: ({ children }) => (
           <Fragment>{children}</Fragment>
       )
   }
)

Then the Code Connect would be:

import { ComponentName } from '@something';
import  figma from `@figma/code-connect`;

const FigmaLink = "..."

const ComponentNameProps = {
   content: figma.boolean("Content", {
      false: undefined,
      true: figma.instance('_ComponentNameContent')
   }),
   action: figma.boolean("Action", {
      false: undefined,
      true: figma.children('_ComponentNameAction')
   })
};

figma.connect(ComponentName, FigmaLink , {
   props: {
      ...ComponentNameProps,
   },
   example: ({ content, action }) => {
      return <ComponentName content={content} action={action} />;
   }
});

Sorry if there's some errors, I had to type this all up from my personal computer since I don't have access to GH on my work computer. Does anyone have any thoughts/solutions?

主要语言
TypeScript
星标
1.6k
派生
126
PR 合并指标
30 天内没有已合并 PR

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

figma/code-connect 的其他 Issue

查看 figma/code-connect 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。