Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

FS spectral correction: parameters lack a reference

Abierto
#2,540 6 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
25/100
Tipo de issue
Documentación
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
python

Línea de trabajo

The coefficients for the cdte product live in pvlib/spectrum/mismatch.py in spectral_factor_firstsolar, and the reference list is in the docs. Start by reading the function's docstring and its cited references, then check the Matlab history the issue links. Done means the citation or private-communication note matches the source of the parameters, which needs a maintainer decision first.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

The first solar spectral correction function spectral.mismatch.spectral_factor_firstsolar provides coefficients for a single cdte product, see here.

The coefficients are different from those found in the primary reference, the 2016 IEEE PVSC paper by M. Lee and A. Panchula [2].

The backstory: this python code was ported from a function provided to PVLib for Matlab by the primary author, Mitchell Lee. The Matlab function was updated by M. Lee with parameters from his 43rd PVSC presentation. It appears that the finalparameters did not make it into the PVSC paper.

The Matlab code has comments that include a set of parameters for FS modules older that Series 4-2, but these parameters aren't those appearing in the paper, either.

I think we need to add a new reference, private communication with M. Lee, to memorialize the source of the built-in parameters. I can't find [4] anywhere, which might contain the parameter values. [4] appears to be a non-public work product from TUV to a client.

Lenguaje dominante
Python
Estrellas
1.7k
Forks
1.2k
Merge medio
3 d 18 h
PR fusionados (30 d)
13

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de pvlib/pvlib-python

Todos los issues de pvlib/pvlib-python

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.