Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Branch deletion modal (0.168.0): "Delete All" reads as deleting the repository, and single deletes need two trips

Abierto
#9,060 0 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@alexr00 ya está trabajando en esto.

Desde el 13/10/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

The branch-deletion modal added in 0.168.0 ("Show branch deletion options in a modal dialog after merging a pull request") makes the most common cleanup harder and makes the safe option look dangerous.

What happens

After merging a PR, clicking Delete Branch... opens:

Choose what to delete for Pull Request #36

Choose an action below to clean up the resources associated with this pull request.

Remote branch: origin/feature-branch
Remote repository: https://github.com/owner/repo
Local branch: feature-branch

[Cancel] [Delete Local Branch] [Delete Remote Branch] [Delete All]

Two problems:

1. "Delete All" reads as "delete the repository too"

The detail text lists three things (remote branch, remote repository, local branch), and the button below says Delete All. Read together, that suggests the repository gets deleted. From the source, it doesn't: the Remote repository: line only shows where the remote branch lives, and Delete All runs the remoteHead and local actions. But nothing in the dialog says so, and nobody should have to read the source to find out whether a button deletes their repo.

So the one-click path, which is what the old checkboxes did by default, is the one a careful user avoids.

2. Without "Delete All", it takes two trips through the dialog

Each per-item button closes the modal. To delete both branches without clicking Delete All, you have to:

  1. click Delete Branch..., choose Delete Local Branch
  2. click Delete Branch... again, choose Delete Remote Branch

Before 0.168.0 this was one quick pick with both branches checked by default, and you could confirm or untick either one.

Suggestions

Any of these would fix it:

  • Drop the Remote repository: line, or fold it into the branch line (e.g. Remote branch: origin/feature-branch (owner/repo)), so the list only contains things that can actually be deleted.
  • Label the combined button by what it deletes, e.g. Delete Local and Remote Branches, and not Delete All.
  • Or go back to the multi-select quick pick, which handled both cases in one step.

Environment

  • GitHub Pull Requests extension: 0.168.0 (not present in 0.166.1)
  • VS Code: 1.141.0
  • macOS 26.6.2
Lenguaje dominante
TypeScript
Estrellas
2.6k
Forks
805
Merge medio
1 d 16 h
PR fusionados (30 d)
42

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de microsoft/vscode-pull-request-github

Todos los issues de microsoft/vscode-pull-request-github

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.