Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Branch deletion modal (0.168.0): "Delete All" reads as deleting the repository, and single deletes need two trips

Ouverte
  • Quelque chose ne va pas ?
#9,060 0 commentaires 0 réactions 1 personne assignée Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@alexr00 y travaille déjà.

Depuis le 13/10/2026.

Évaluation

Cette issue n'a pas encore été évaluée.

Description

The branch-deletion modal added in 0.168.0 ("Show branch deletion options in a modal dialog after merging a pull request") makes the most common cleanup harder and makes the safe option look dangerous.

What happens

After merging a PR, clicking Delete Branch... opens:

Choose what to delete for Pull Request #36

Choose an action below to clean up the resources associated with this pull request.

Remote branch: origin/feature-branch
Remote repository: https://github.com/owner/repo
Local branch: feature-branch

[Cancel] [Delete Local Branch] [Delete Remote Branch] [Delete All]

Two problems:

1. "Delete All" reads as "delete the repository too"

The detail text lists three things (remote branch, remote repository, local branch), and the button below says Delete All. Read together, that suggests the repository gets deleted. From the source, it doesn't: the Remote repository: line only shows where the remote branch lives, and Delete All runs the remoteHead and local actions. But nothing in the dialog says so, and nobody should have to read the source to find out whether a button deletes their repo.

So the one-click path, which is what the old checkboxes did by default, is the one a careful user avoids.

2. Without "Delete All", it takes two trips through the dialog

Each per-item button closes the modal. To delete both branches without clicking Delete All, you have to:

  1. click Delete Branch..., choose Delete Local Branch
  2. click Delete Branch... again, choose Delete Remote Branch

Before 0.168.0 this was one quick pick with both branches checked by default, and you could confirm or untick either one.

Suggestions

Any of these would fix it:

  • Drop the Remote repository: line, or fold it into the branch line (e.g. Remote branch: origin/feature-branch (owner/repo)), so the list only contains things that can actually be deleted.
  • Label the combined button by what it deletes, e.g. Delete Local and Remote Branches, and not Delete All.
  • Or go back to the multi-select quick pick, which handled both cases in one step.

Environment

  • GitHub Pull Requests extension: 0.168.0 (not present in 0.166.1)
  • VS Code: 1.141.0
  • macOS 26.6.2
Langage dominant
TypeScript
Étoiles
2.6k
Forks
805
Merge moyen
1 j 12 h
PR mergées (30 j)
39

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de microsoft/vscode-pull-request-github

Toutes les issues de microsoft/vscode-pull-request-github

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.