Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Branch deletion modal (0.168.0): "Delete All" reads as deleting the repository, and single deletes need two trips

Aperta
  • Qualcosa non va?
#9,060 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@alexr00 ci sta già lavorando.

Dal 13/10/2026.

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

The branch-deletion modal added in 0.168.0 ("Show branch deletion options in a modal dialog after merging a pull request") makes the most common cleanup harder and makes the safe option look dangerous.

What happens

After merging a PR, clicking Delete Branch... opens:

Choose what to delete for Pull Request #36

Choose an action below to clean up the resources associated with this pull request.

Remote branch: origin/feature-branch
Remote repository: https://github.com/owner/repo
Local branch: feature-branch

[Cancel] [Delete Local Branch] [Delete Remote Branch] [Delete All]

Two problems:

1. "Delete All" reads as "delete the repository too"

The detail text lists three things (remote branch, remote repository, local branch), and the button below says Delete All. Read together, that suggests the repository gets deleted. From the source, it doesn't: the Remote repository: line only shows where the remote branch lives, and Delete All runs the remoteHead and local actions. But nothing in the dialog says so, and nobody should have to read the source to find out whether a button deletes their repo.

So the one-click path, which is what the old checkboxes did by default, is the one a careful user avoids.

2. Without "Delete All", it takes two trips through the dialog

Each per-item button closes the modal. To delete both branches without clicking Delete All, you have to:

  1. click Delete Branch..., choose Delete Local Branch
  2. click Delete Branch... again, choose Delete Remote Branch

Before 0.168.0 this was one quick pick with both branches checked by default, and you could confirm or untick either one.

Suggestions

Any of these would fix it:

  • Drop the Remote repository: line, or fold it into the branch line (e.g. Remote branch: origin/feature-branch (owner/repo)), so the list only contains things that can actually be deleted.
  • Label the combined button by what it deletes, e.g. Delete Local and Remote Branches, and not Delete All.
  • Or go back to the multi-select quick pick, which handled both cases in one step.

Environment

  • GitHub Pull Requests extension: 0.168.0 (not present in 0.166.1)
  • VS Code: 1.141.0
  • macOS 26.6.2
Lingua principale
TypeScript
Stelle
2.6k
Fork
805
Merge medio
1g 16h
PR unite (30g)
42

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di microsoft/vscode-pull-request-github

Tutte le issue di microsoft/vscode-pull-request-github

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.