Visitor charts silently drop the most recent day of GA data

Abierto
#946 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
html, python

Línea de trabajo

Read layouts/shortcodes/ga_daily_visitors.html and layouts/shortcodes/ga_daily_visitors_yearly.html around the dailyData.pop() calls, then check how the charts are rendered on the page. Decide whether to document the omitted latest day in code and on the chart, or confirm the current behavior is intentional; the issue says removing pop() alone would expose provisional data.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

layouts/shortcodes/ga_daily_visitors.html:9 and layouts/shortcodes/ga_daily_visitors_yearly.html:11 sort the data and then call dailyData.pop(), which removes the most recent date from the visitor charts. Nothing in the code or on the page says so.

The drop looks deliberate and may be correct. scripts/download_ga_data.py requests end_date="today", and the workflow runs just after midnight UTC, so the last row is the day that has just ended. That day's figure can be provisional: comparing the yearly series in the 1 Oct and 1 Nov 2026 files, the only overlapping date that changed is 30 Sep, the last day of the 1 Oct file, which went from 508 to 526 users.

Do not simply remove pop(), because the chart would then show an undercounted last day. Options: add a code comment and a chart note explaining the drop, or close this as intended behaviour. Requesting end_date="yesterday" would not help on its own, since a run just after midnight would still fetch the day that has just ended.

Found during PR triage (#936 did not introduce this).

Lenguaje dominante
HTML
Estrellas
42
Forks
33
Merge medio
17 h 18 min
PR fusionados (30 d)
111

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de forrtproject/forrtproject.github.io

Todos los issues de forrtproject/forrtproject.github.io

Issues similares

Más issues de Data Visualization

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.