Visitor charts silently drop the most recent day of GA data

未关闭
#946 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
html, python

调研方向

Read layouts/shortcodes/ga_daily_visitors.html and layouts/shortcodes/ga_daily_visitors_yearly.html around the dailyData.pop() calls, then check how the charts are rendered on the page. Decide whether to document the omitted latest day in code and on the chart, or confirm the current behavior is intentional; the issue says removing pop() alone would expose provisional data.

由索引模型根据 Issue 内容生成。

描述

layouts/shortcodes/ga_daily_visitors.html:9 and layouts/shortcodes/ga_daily_visitors_yearly.html:11 sort the data and then call dailyData.pop(), which removes the most recent date from the visitor charts. Nothing in the code or on the page says so.

The drop looks deliberate and may be correct. scripts/download_ga_data.py requests end_date="today", and the workflow runs just after midnight UTC, so the last row is the day that has just ended. That day's figure can be provisional: comparing the yearly series in the 1 Oct and 1 Nov 2026 files, the only overlapping date that changed is 30 Sep, the last day of the 1 Oct file, which went from 508 to 526 users.

Do not simply remove pop(), because the chart would then show an undercounted last day. Options: add a code comment and a chart note explaining the drop, or close this as intended behaviour. Requesting end_date="yesterday" would not help on its own, since a run just after midnight would still fetch the day that has just ended.

Found during PR triage (#936 did not introduce this).

主要语言
HTML
星标
42
派生
33
平均合并
17 小时 18 分钟
30 天内合并 PR
111

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

forrtproject/forrtproject.github.io 的其他 Issue

查看 forrtproject/forrtproject.github.io 的全部 Issue

相似的 Issue

更多 Data Visualization Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。