Visitor charts silently drop the most recent day of GA data

Ouverte
#946 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
2/5
Temps estimé
1-3 heures
Accessibilité débutants
48/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
html, python

Piste de recherche

Read layouts/shortcodes/ga_daily_visitors.html and layouts/shortcodes/ga_daily_visitors_yearly.html around the dailyData.pop() calls, then check how the charts are rendered on the page. Decide whether to document the omitted latest day in code and on the chart, or confirm the current behavior is intentional; the issue says removing pop() alone would expose provisional data.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

layouts/shortcodes/ga_daily_visitors.html:9 and layouts/shortcodes/ga_daily_visitors_yearly.html:11 sort the data and then call dailyData.pop(), which removes the most recent date from the visitor charts. Nothing in the code or on the page says so.

The drop looks deliberate and may be correct. scripts/download_ga_data.py requests end_date="today", and the workflow runs just after midnight UTC, so the last row is the day that has just ended. That day's figure can be provisional: comparing the yearly series in the 1 Oct and 1 Nov 2026 files, the only overlapping date that changed is 30 Sep, the last day of the 1 Oct file, which went from 508 to 526 users.

Do not simply remove pop(), because the chart would then show an undercounted last day. Options: add a code comment and a chart note explaining the drop, or close this as intended behaviour. Requesting end_date="yesterday" would not help on its own, since a run just after midnight would still fetch the day that has just ended.

Found during PR triage (#936 did not introduce this).

Langage dominant
HTML
Étoiles
42
Forks
33
Merge moyen
16 h 3 min
PR mergées (30 j)
121

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de forrtproject/forrtproject.github.io

Toutes les issues de forrtproject/forrtproject.github.io

Issues similaires

Plus d'issues Data Visualization

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.