Preview pane: a late ready kept through a navigation, and a new token on the form's reload

Abierto
#3,470 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
47/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp
Área
backend, testing

Línea de trabajo

Read ContentPreview.razor and its LoadedAsync method, then inspect ContentForm.razor and the existing component tests for both behaviors. Trace how ready state and the pane token change across navigation and form reload; use the tests to check the acceptance cases, including the documented contract limit in section 4.12 if that approach is chosen.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:admin type:bug

Problem

Two cases of the preview pane that the review of #3437 (#3403) left for later:

  • A page that says ready after its own load keeps ready through a navigation to a page without the contract. The pane forgets ready when the frame loads a page with no ready since the previous load (ContentPreview.razor, LoadedAsync). For the order load 1, ready 1, load 2 with no ready, the flag is still true from ready 1 when load 2 arrives, so the next save posts refresh to a page that ignores it: nothing reloads and the Silent note never shows. Front ends that post ready after hydration or after a data fetch send it in that order. The rule cannot tell this from a ready that is merely delivered late, which #3403 settled; the component test and the end-to-end case cover only ready before the load.
  • Reloading the form re-creates the open pane, which mints again while its token lasts. ContentForm.razor sets its read to null before the first await of LoadAsync, so the pane's condition turns false and the pane is disposed; when the read ends a new pane mints as it opens. The conflict dialog's Reload and Try again, on the same entry and locale, so give a new token that cannot be revoked and reload the frame.

Proposal

  • Tell the two orders apart, or ask a contract page to post navigated before a full navigation and say so in section 4.12; whichever is chosen, record the limit in 4.12.
  • Keep the pane, its answer and its token across a reload of the same entry, site and locale.

Acceptance

  • A page that says ready after its load and then navigates to a page without the contract is reloaded on the next save, or section 4.12 states the limit and the contract asks for navigated
  • The conflict dialog's Reload and Try again on the same entry and locale mint no token while the shown one lasts
  • Component tests for both, and an end-to-end case for the first if the contract changes

From the second review of #3437 (#3403).

Lenguaje dominante
C#
Estrellas
567
Forks
107
Merge medio
1 h 19 min
PR fusionados (30 d)
353

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fluentcms/FluentCMS

Todos los issues de fluentcms/FluentCMS

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.