Preview pane: a late ready kept through a navigation, and a new token on the form's reload

未关闭
#3,470 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
47/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
csharp
领域
backend, testing

调研方向

Read ContentPreview.razor and its LoadedAsync method, then inspect ContentForm.razor and the existing component tests for both behaviors. Trace how ready state and the pane token change across navigation and form reload; use the tests to check the acceptance cases, including the documented contract limit in section 4.12 if that approach is chosen.

由索引模型根据 Issue 内容生成。

描述

area:admin type:bug

Problem

Two cases of the preview pane that the review of #3437 (#3403) left for later:

  • A page that says ready after its own load keeps ready through a navigation to a page without the contract. The pane forgets ready when the frame loads a page with no ready since the previous load (ContentPreview.razor, LoadedAsync). For the order load 1, ready 1, load 2 with no ready, the flag is still true from ready 1 when load 2 arrives, so the next save posts refresh to a page that ignores it: nothing reloads and the Silent note never shows. Front ends that post ready after hydration or after a data fetch send it in that order. The rule cannot tell this from a ready that is merely delivered late, which #3403 settled; the component test and the end-to-end case cover only ready before the load.
  • Reloading the form re-creates the open pane, which mints again while its token lasts. ContentForm.razor sets its read to null before the first await of LoadAsync, so the pane's condition turns false and the pane is disposed; when the read ends a new pane mints as it opens. The conflict dialog's Reload and Try again, on the same entry and locale, so give a new token that cannot be revoked and reload the frame.

Proposal

  • Tell the two orders apart, or ask a contract page to post navigated before a full navigation and say so in section 4.12; whichever is chosen, record the limit in 4.12.
  • Keep the pane, its answer and its token across a reload of the same entry, site and locale.

Acceptance

  • A page that says ready after its load and then navigates to a page without the contract is reloaded on the next save, or section 4.12 states the limit and the contract asks for navigated
  • The conflict dialog's Reload and Try again on the same entry and locale mint no token while the shown one lasts
  • Component tests for both, and an end-to-end case for the first if the contract changes

From the second review of #3437 (#3403).

主要语言
C#
星标
567
派生
107
平均合并
1 小时 19 分钟
30 天内合并 PR
353

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

fluentcms/FluentCMS 的其他 Issue

查看 fluentcms/FluentCMS 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。